commit 4d15068d83054a9f82b3f8842706cd6deb401e25
author Vladislav Grishenko <themiron@mail.ru> Thu Mar 19 16:19:35 2015 +0500
committer Denys Vlasenko <vda.linux@googlemail.com> Sun Mar 22 17:59:34 2015 +0100
tree 8becf05987b05a43bf6e56b674d65e7adac9805f
parent 911db16229d41f53b9c44272fcccdb3552a5a99e

zcip: fix wrong comparison of source IP with our IP

Commit "zcip: fix link-local IP conflict detection" has introduced
wrong comparsion of source IP with our IP. This leads to a new IP
being picked unnecessarily on every incoming ARP packet.

Signed-off-by: Vladislav Grishenko <themiron@mail.ru>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

networking/zcip.c

diff --git a/networking/zcip.c b/networking/zcip.c
index a3307c5..962ba2e 100644
--- a/networking/zcip.c
+++ b/networking/zcip.c
@@ -521,7 +521,7 @@
 			target_ip_conflict = 0;
 
 			if (memcmp(&p.arp.arp_sha, &eth_addr, ETH_ALEN) != 0) {
-				if (memcmp(p.arp.arp_spa, &ip.s_addr, sizeof(struct in_addr))) {
+				if (memcmp(p.arp.arp_spa, &ip.s_addr, sizeof(struct in_addr)) == 0) {
 					/* A probe or reply with source_ip == chosen ip */
 					source_ip_conflict = 1;
 				}