Further optimize applet tables; prettify build output
text data bss dec hex filename
775923 929 9100 785952 bfe20 busybox_old
775565 929 9100 785594 bfcba busybox_unstripped
diff --git a/libbb/appletlib.c b/libbb/appletlib.c
index dcf24f5..d5a2d06 100644
--- a/libbb/appletlib.c
+++ b/libbb/appletlib.c
@@ -101,19 +101,17 @@
}
+/* NB: any char pointer will work as well, not necessarily applet_names */
static int applet_name_compare(const void *name, const void *v)
{
int i = (const char *)v - applet_names;
return strcmp(name, APPLET_NAME(i));
}
-
int find_applet_by_name(const char *name)
{
- const char *p;
/* Do a binary search to find the applet entry given the name. */
-
- /* NB: any char pointer will work as well, not necessarily applet_names */
- p = bsearch(name, applet_names, ARRAY_SIZE(applet_mains), 1, applet_name_compare);
+ const char *p;
+ p = bsearch(name, applet_names, ARRAY_SIZE(applet_main), 1, applet_name_compare);
if (!p)
return -1;
return p - applet_names;
@@ -543,10 +541,12 @@
if (use_symbolic_links)
lf = symlink;
- for (i = 0; i < ARRAY_SIZE(applet_mains); i++) {
+ for (i = 0; i < ARRAY_SIZE(applet_main); i++) {
fpc = concat_path_file(
install_dir[APPLET_INSTALL_LOC(i)],
APPLET_NAME(i));
+ // debug: bb_error_msg("%slinking %s to busybox",
+ // use_symbolic_links ? "sym" : "", fpc);
rc = lf(busybox, fpc);
if (rc != 0 && errno != EEXIST) {
bb_simple_perror_msg(fpc);
@@ -644,7 +644,7 @@
bb_show_usage();
if (ENABLE_FEATURE_SUID)
check_suid(applet_no);
- exit(applet_mains[applet_no](argc, argv));
+ exit(applet_main[applet_no](argc, argv));
}
void run_applet_and_exit(const char *name, char **argv)