Denis Vlasenko | e471275 | 2007-04-14 15:08:41 +0000 | [diff] [blame] | 1 | Various bits of what is known about busybox shells, in no particular order. |
| 2 | |
Denis Vlasenko | 163a855 | 2007-05-24 13:52:46 +0000 | [diff] [blame] | 3 | 2007-05-24 |
Denis Vlasenko | d76c049 | 2007-05-25 02:16:25 +0000 | [diff] [blame^] | 4 | hush: environment-related memory leak plugged, with net code size |
| 5 | decrease. |
| 6 | |
| 7 | 2007-05-24 |
Denis Vlasenko | 163a855 | 2007-05-24 13:52:46 +0000 | [diff] [blame] | 8 | hush: '( echo ${name )' will show syntax error message, but prompt |
| 9 | doesn't return (need to press <enter>). Pressing Ctrl-C, <enter>, |
| 10 | '( echo ${name )' again, Ctrl-C segfaults. |
| 11 | |
Denis Vlasenko | 8805eeb | 2007-05-21 10:19:48 +0000 | [diff] [blame] | 12 | 2007-05-21 |
| 13 | hush: environment cannot be handled by libc routines as they are leaky |
| 14 | (by API design and thus unfixable): hush will leak memory in this script, |
| 15 | bash does not: |
| 16 | pid=$$ |
| 17 | while true; do |
| 18 | unset t; |
| 19 | t=111111111111111111111111111111111111111111111111111111111111111111111111 |
| 20 | export t |
| 21 | ps -o vsz,pid,comm | grep " $pid " |
| 22 | done |
| 23 | The fix is to not use setenv/putenv/unsetenv but manipulate env ourself. TODO. |
| 24 | hush: meanwhile, first three command subst bugs mentioned below are fixed. :) |
| 25 | |
| 26 | 2007-05-06 |
Denis Vlasenko | 21f0d4c | 2007-05-06 14:15:42 +0000 | [diff] [blame] | 27 | hush: more bugs spotted. Comparison with bash: |
| 28 | bash-3.2# echo "TEST`date;echo;echo`BEST" |
| 29 | TESTSun May 6 09:21:05 CEST 2007BEST [we dont strip eols] |
| 30 | bash-3.2# echo "TEST`echo '$(echo ZZ)'`BEST" |
| 31 | TEST$(echo ZZ)BEST [we execute inner echo] |
| 32 | bash-3.2# echo "TEST`echo "'"`BEST" |
| 33 | TEST'BEST [we totally mess up this one] |
| 34 | bash-3.2# echo `sleep 5` |
| 35 | [Ctrl-C should work, Ctrl-Z should do nothing][we totally mess up this one] |
| 36 | bash-3.2# if true; then |
| 37 | > [Ctrl-C] |
| 38 | bash-3.2# [we re-issue "> "] |
| 39 | bash-3.2# if echo `sleep 5`; then |
| 40 | > true; fi [we execute sleep before "> "] |
| 41 | |
Denis Vlasenko | ac0e5ab | 2007-05-04 21:37:27 +0000 | [diff] [blame] | 42 | 2007-05-04 |
Denis Vlasenko | 21f0d4c | 2007-05-06 14:15:42 +0000 | [diff] [blame] | 43 | hush: made ctrl-Z/C work correctly for "while true; do true; done" |
| 44 | (namely, it backgrounds/interrupts entire "while") |
Denis Vlasenko | ac0e5ab | 2007-05-04 21:37:27 +0000 | [diff] [blame] | 45 | |
Denis Vlasenko | e725bfe | 2007-05-03 22:45:39 +0000 | [diff] [blame] | 46 | 2007-05-03 |
Denis Vlasenko | 3349fc4 | 2007-05-04 14:54:36 +0000 | [diff] [blame] | 47 | hush: new bug spotted: Ctrl-C on "while true; do true; done" doesn't |
| 48 | work right: |
| 49 | # while true; do true; done |
| 50 | [1] 0 true <-- pressing Ctrl-C several times... |
| 51 | [2] 0 true |
| 52 | [3] 0 true |
| 53 | Segmentation fault |
Denis Vlasenko | 400c5b6 | 2007-05-04 13:07:27 +0000 | [diff] [blame] | 54 | |
| 55 | 2007-05-03 |
Denis Vlasenko | e725bfe | 2007-05-03 22:45:39 +0000 | [diff] [blame] | 56 | hush: update on "sleep 1 | exit 3; echo $?" bug. |
| 57 | parse_stream_outer() repeatedly calls parse_stream(). |
| 58 | parse_stream() is now fixed to stop on ';' in this example, |
| 59 | fixing it (parse_stream_outer() will call parse_stream() 1st time, |
| 60 | execute the parse tree, call parse_stream() 2nd time and execute the tree). |
| 61 | But it's not the end of story. |
| 62 | In more complex situations we _must_ parse way farther before executing. |
| 63 | Example #2: "{ sleep 1 | exit 3; echo $?; ...few_lines... } >file". |
| 64 | Because of redirection, we cannot execute 1st pipe before we parse it all. |
| 65 | We probably need to learn to store $var expressions in parse tree. |
| 66 | Debug printing of parse tree would be nice too. |
| 67 | |
Denis Vlasenko | 08c8c1d | 2007-04-28 22:39:02 +0000 | [diff] [blame] | 68 | 2007-04-28 |
| 69 | hush: Ctrl-C and Ctrl-Z for single NOFORK commands are working. |
| 70 | Memory and other resource leaks (opendir) are not addressed |
| 71 | (testcase is "rm -i" interrupted by ctrl-c). |
| 72 | |
Denis Vlasenko | 52881e9 | 2007-04-21 13:42:52 +0000 | [diff] [blame] | 73 | 2007-04-21 |
Denis Vlasenko | 1359da6 | 2007-04-21 23:27:30 +0000 | [diff] [blame] | 74 | hush: "sleep 5 | sleep 6" + Ctrl-Z + fg seems to work. |
| 75 | "rm -i" + Ctrl-C, "sleep 5" + Ctrl-Z still doesn't work |
| 76 | for SH_STANDALONE case :( |
| 77 | |
| 78 | 2007-04-21 |
Denis Vlasenko | 52881e9 | 2007-04-21 13:42:52 +0000 | [diff] [blame] | 79 | hush: fixed non-backgrounding of "sleep 1 &" and totally broken |
| 80 | "sleep 1 | sleep 2 &". Noticed a bug where successive jobs |
| 81 | get numbers 1,2,3 even when job #1 has exited before job# 2 is started. |
| 82 | (bash reuses #1 in this case) |
| 83 | |
| 84 | 2007-04-21 |
Denis Vlasenko | 2f1bb36 | 2007-04-21 10:01:14 +0000 | [diff] [blame] | 85 | hush: "sleep 1 | exit 3; echo $?" prints 0 because $? is substituted |
| 86 | _before_ pipe gets executed!! run_list_real() already has "pipe;echo" |
| 87 | parsed and handed to it for execution, so it sees "pipe"; "echo 0". |
| 88 | |
Denis Vlasenko | 54e7ffb | 2007-04-21 00:03:36 +0000 | [diff] [blame] | 89 | 2007-04-21 |
| 90 | hush: removed setsid() and made job control sort-of-sometimes-work. |
| 91 | Ctrl-C in "rm -i" works now except for SH_STANDALONE case. |
| 92 | "sleep 1 | exit 3" + "echo $?" works, "sleep 1 | exit 3; echo $?" |
| 93 | shows exitcode 0 (should be 3). "sleep 1 | sleep 2 &" fails horribly. |
| 94 | |
Denis Vlasenko | e471275 | 2007-04-14 15:08:41 +0000 | [diff] [blame] | 95 | 2007-04-14 |
| 96 | lash, hush: both do setsid() and as a result don't have ctty! |
| 97 | Ctrl-C doesn't work for any child (try rm -i), etc... |
| 98 | lash: bare ">file" doesn't create a file (hush works) |