commit ca2722063504bff28db85a7048a70f6925db75c9
author slv <slv@codeaurora.org> Tue Oct 27 17:05:16 2015 +0800
committer slv <slv@codeaurora.org> Tue Oct 27 17:05:16 2015 +0800
tree db98d0fe4dd2d62c7e429565dd7c8875b0e16c4f
parent 8f830456aab5411198b94fea76d5bc729d66c567

[qca-ssdk]code review optimize

code review optimize

Change-Id: Ibe0fa7886714b1f236336fc4dc3354401fe41fd1
Signed-off-by: slv <slv@codeaurora.org>

src/hsl/dess/dess_acl.c

diff --git a/src/hsl/dess/dess_acl.c b/src/hsl/dess/dess_acl.c
index 9591640..6b7522d 100755
--- a/src/hsl/dess/dess_acl.c
+++ b/src/hsl/dess/dess_acl.c
@@ -41,6 +41,8 @@
 static sw_error_t
 _dess_filter_valid_set(a_uint32_t dev_id, a_uint32_t flt_idx, a_uint32_t flag);
 
+#ifndef DESS_SW_ENTRY
+#ifndef DESS_HW_ENTRY
 static sw_error_t
 _dess_filter_ports_bind(a_uint32_t dev_id, a_uint32_t flt_idx,
                         a_uint32_t ports);
@@ -48,6 +50,8 @@
 static sw_error_t
 _dess_filter_write(a_uint32_t dev_id, a_uint32_t reg[], a_uint32_t flt_idx,
                    a_uint32_t op);
+#endif
+#endif
 
 static sw_error_t
 _dess_filter_read(a_uint32_t dev_id, a_uint32_t reg[], a_uint32_t flt_idx,

src/hsl/isis/isis_acl.c

diff --git a/src/hsl/isis/isis_acl.c b/src/hsl/isis/isis_acl.c
index 646c6b8..55a8027 100755
--- a/src/hsl/isis/isis_acl.c
+++ b/src/hsl/isis/isis_acl.c
@@ -161,6 +161,7 @@
     filter.msk[4] |= (flag & 0x7);
 
     _isis_filter_down_to_hw(dev_id, &filter, flt_idx);
+    return SW_OK;
 #else
     sw_error_t rv;
     a_uint32_t addr, data = 0;

src/hsl/isis/isis_multicast_acl.c

diff --git a/src/hsl/isis/isis_multicast_acl.c b/src/hsl/isis/isis_multicast_acl.c
index e67d88f..9b08266 100755
--- a/src/hsl/isis/isis_multicast_acl.c
+++ b/src/hsl/isis/isis_multicast_acl.c
@@ -400,7 +400,7 @@
     //a_uint32_t list_pos;
     a_uint32_t rule_pos;
     a_uint32_t list_pri;
-    sw_error_t rv;
+    sw_error_t rv = SW_OK;
 
     //if(entry->port_map < 1 || acl_index<0)
     if(acl_index<0)

src/hsl/isisc/isisc_acl.c

diff --git a/src/hsl/isisc/isisc_acl.c b/src/hsl/isisc/isisc_acl.c
index 320b7f1..ae69c3b 100755
--- a/src/hsl/isisc/isisc_acl.c
+++ b/src/hsl/isisc/isisc_acl.c
@@ -165,6 +165,7 @@
     filter.msk[4] |= (flag & 0x7);
 
     _isisc_filter_down_to_hw(dev_id, &filter, flt_idx);
+    return SW_OK;
 #else
     sw_error_t rv;
     a_uint32_t addr, data = 0;