commit 07a62cc236978a0f01ec8be70bdd1d3e8fa27f71
author Damjan Marion <damarion@cisco.com> Thu Nov 16 19:14:12 2023 +0000
committer Ole Tr�an <otroan@employees.org> Fri Nov 24 13:25:26 2023 +0000
tree 4b1b01b42a0deaa75faa83dd4c2fb9bbd2bffddc
parent 20e37d2639d54f7bf6ec28e80f3da1f7316f16a2

dev: fix null dereference of arg list

Type: fix
Fixes: 69768d9
Change-Id: Iafd3a55634583f2799a81c477ccbf5e53b6f29d0
Signed-off-by: Damjan Marion <damarion@cisco.com>

src/vnet/dev/api.c

diff --git a/src/vnet/dev/api.c b/src/vnet/dev/api.c
index 260bc7b..72811f5 100644
--- a/src/vnet/dev/api.c
+++ b/src/vnet/dev/api.c
@@ -90,9 +90,10 @@
     }
   dev->description = dev_desc;
 
-  for (vnet_dev_arg_t *a = driver->registration->args;
-       a->type != VNET_DEV_ARG_END; a++)
-    vec_add1 (dev->args, *a);
+  if (driver->registration->args)
+    for (vnet_dev_arg_t *a = driver->registration->args;
+	 a->type != VNET_DEV_ARG_END; a++)
+      vec_add1 (dev->args, *a);
 
   if (args->args)
     {

src/vnet/dev/port.c

diff --git a/src/vnet/dev/port.c b/src/vnet/dev/port.c
index b3f4035..0363ea4 100644
--- a/src/vnet/dev/port.c
+++ b/src/vnet/dev/port.c
@@ -267,8 +267,9 @@
   port->rx_node = *args->rx_node;
   port->tx_node = *args->tx_node;
 
-  for (vnet_dev_arg_t *a = args->port.args; a->type != VNET_DEV_ARG_END; a++)
-    vec_add1 (port->args, *a);
+  if (args->port.args)
+    for (vnet_dev_arg_t *a = args->port.args; a->type != VNET_DEV_ARG_END; a++)
+      vec_add1 (port->args, *a);
 
   /* defaults out of port attributes */
   port->max_rx_frame_size = args->port.attr.max_supported_rx_frame_size;