commit 07dce1e11de9872b5c9695e8cbbf89a2bcb3f63d
author Marek Gradzki <mgradzki@cisco.com> Tue Mar 06 11:42:36 2018 +0100
committer Ole Trøan <otroan@employees.org> Tue Mar 06 12:54:57 2018 +0000
tree 72d2a9b3a91d8964d714457655134ef4437d9a50
parent b533f3fadeab73aef04b6fd65ab997ed7fce50df

vppapigen: require service definition for singleton messages

Change-Id: Ie7b1c5e50588f65657c3c0900e5914ea82ebb50f
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>

src/tools/vppapigen/vppapigen.py

diff --git a/src/tools/vppapigen/vppapigen.py b/src/tools/vppapigen/vppapigen.py
index 57e5e3a..e6237a7 100755
--- a/src/tools/vppapigen/vppapigen.py
+++ b/src/tools/vppapigen/vppapigen.py
@@ -601,10 +601,6 @@
                 continue
             if msgs[d].singular is True:
                 continue
-            #if d.endswith('_counters'):
-            #    continue
-            #if d.endswith('_event'):
-            #    continue
             if d.endswith('_reply'):
                 if d[:-6] in svcs:
                     continue
@@ -634,9 +630,8 @@
             if d+'_reply' in msgs:
                 s['services'].append(Service(d, d+'_reply'))
             else:
-                self.logger.warning('{} missing reply message ({})'
-                                    .format(d, d+'_reply'))
-                s['services'].append(Service(d, None))
+                raise ValueError('{} missing reply message ({}) or service definition'
+                                 .format(d, d+'_reply'))
 
         return s