commit 0c740a6d8a6c11b1af4ce704220c2c46628f0a89
author Mohsin Kazmi <sykazmi@cisco.com> Tue Apr 05 11:12:33 2022 +0000
committer Damjan Marion <dmarion@me.com> Tue Apr 05 14:23:02 2022 +0000
tree 0feb2d1bc91b74d5f46262fcae784bd0ce1a406a
parent 61a2c8939d188ce2fc033695fe6dbf84b4ad61a6

tap: fix the coverity warning

Type: fix

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: I609fb28e58286ff490d12384b03dd713830379b3

src/vnet/devices/tap/tap.c

diff --git a/src/vnet/devices/tap/tap.c b/src/vnet/devices/tap/tap.c
index b7ccba9..360c001 100644
--- a/src/vnet/devices/tap/tap.c
+++ b/src/vnet/devices/tap/tap.c
@@ -334,10 +334,10 @@
 	  args->error = clib_error_return_unix (0, "open '/dev/net/tun'");
 	  goto error;
 	}
+      vec_add1 (vif->tap_fds, qfd);
       _IOCTL (qfd, TUNSETIFF, (void *) &ifr);
       tap_log_dbg (vif, "TUNSETIFF fd %d name %s flags 0x%x", qfd,
 		   ifr.ifr_ifrn.ifrn_name, ifr.ifr_flags);
-      vec_add1 (vif->tap_fds, qfd);
     }
 
   for (i = 0; i < vif->num_rxqs; i++)