commit 0d3d4824a46205e776ff32c82be4cb514f459a5f
author Andrew Yourtchenko <ayourtch@gmail.com> Mon Nov 25 18:25:46 2019 +0000
committer Florin Coras <florin.coras@gmail.com> Mon Nov 25 20:30:37 2019 +0000
tree 1490a7d9f97867670b03321e23b8d0d14f141eb0
parent 599db9e9d0c61ac39b16cc572f975cdc70c07783

tap: fix coverity warning 205875

check the return result from fcntl, and if error, behave
the same way the expansion of _IOCTL macro does.

Type: fix
Change-Id: I6d537d1bdedae64470612aef64b46e07387fe84b
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

src/vnet/devices/tap/tap.c

diff --git a/src/vnet/devices/tap/tap.c b/src/vnet/devices/tap/tap.c
index 5f6d720..288099e 100644
--- a/src/vnet/devices/tap/tap.c
+++ b/src/vnet/devices/tap/tap.c
@@ -223,7 +223,12 @@
   else
     host_if_name = (char *) args->host_if_name;
 
-  fcntl (tfd, F_SETFL, O_NONBLOCK);
+  if (fcntl (tfd, F_SETFL, O_NONBLOCK) < 0)
+    {
+      err = clib_error_return_unix (0, "fcntl(tfd, F_SETFL, O_NONBLOCK)");
+      tap_log_err (vif, "set nonblocking: %U", format_clib_error, err);
+      goto error;
+    }
 
   tap_log_dbg (vif, "TUNSETVNETHDRSZ: fd %d vnet_hdr_sz %u", tfd, hdrsz);
   _IOCTL (tfd, TUNSETVNETHDRSZ, &hdrsz);