commit 0d65d11053395bde7bd8c36439e9025e50ea8028
author Dave Barach <dave@barachs.net> Fri Mar 16 15:21:35 2018 -0400
committer Damjan Marion <dmarion.lists@gmail.com> Fri Mar 16 20:28:13 2018 +0000
tree e893ef41493550da42dcb6486b8c1c33a4b934b3
parent c03742346f0f3f08b83b0d2944bf72e19ea26191

Fix a long-latent bi=0 bug in vlib_buffer_add_data

Change vlib_buffer_add_data() so it interprets ~0 to mean please
allocate a new buffer, instead of 0. Fixed a couple of calls to pass
~0 instead of 0.

Zero has always been a valid buffer index, we never happened to
actually use it until recent buffer allocator changes.

The presenting symptom: ASSERT failure when running "make
TEST=test_mpls test-debug"

Change-Id: Ic909913c1d464b3434d6d47e0c58f978806854d5
Signed-off-by: Dave Barach <dave@barachs.net>

src/vnet/srp/node.c

diff --git a/src/vnet/srp/node.c b/src/vnet/srp/node.c
index 9123c4c..acb770e 100644
--- a/src/vnet/srp/node.c
+++ b/src/vnet/srp/node.c
@@ -334,7 +334,7 @@
     u32 bi;
 
     bi = vlib_buffer_add_data (vm, VLIB_BUFFER_DEFAULT_FREE_LIST_INDEX,
-			       /* buffer to append to */ 0,
+			       /* buffer to append to */ ~0,
 			       *contents, vec_len (*contents));
     b = vlib_get_buffer (vm, bi);
     vnet_buffer (b)->sw_if_index[VLIB_RX] = vnet_buffer (b)->sw_if_index[VLIB_TX] = sw_if_index;
@@ -621,7 +621,7 @@
 					      sizeof (i[0]) - STRUCT_OFFSET_OF (srp_ips_header_t, control)));
 
   bi = vlib_buffer_add_data (vm, VLIB_BUFFER_DEFAULT_FREE_LIST_INDEX,
-			     /* buffer to append to */ 0,
+			     /* buffer to append to */ ~0,
 			     i, sizeof (i[0]));
 
   /* FIXME trace. */