commit 1017a1d360cc1c38e2aee4b5f19ff1f2869a8cd9
author Mohsin Kazmi <sykazmi@cisco.com> Fri Sep 25 15:36:19 2020 +0200
committer Beno�t Ganne <bganne@cisco.com> Mon Sep 28 12:32:16 2020 +0000
tree c1e962d553c993afd0ddf582ff838f7ed9be0371
parent 2fca85b3a171db19e0517a7a43c8029f5d24e6fa

virtio: fix the gro enable/disable on tx-vrings

Type: fix

Change-Id: I96c30baaf34fe7b0cd899966a507501e58cde934
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

src/vnet/devices/tap/cli.c

diff --git a/src/vnet/devices/tap/cli.c b/src/vnet/devices/tap/cli.c
index 7580d92..89b2ff0 100644
--- a/src/vnet/devices/tap/cli.c
+++ b/src/vnet/devices/tap/cli.c
@@ -142,7 +142,7 @@
     "[host-ip4-addr <ip4addr/mask>] [host-ip6-addr <ip6-addr>] "
     "[host-ip4-gw <ip4-addr>] [host-ip6-gw <ip6-addr>] "
     "[host-mac-addr <host-mac-address>] [host-if-name <name>] "
-    "[host-mtu-size <size>] [no-gso|gso|csum-offload|gro-coalesce] "
+    "[host-mtu-size <size>] [no-gso|gso [gro-coalesce]|csum-offload] "
     "[persist] [attach] [tun] [packed] [in-order]",
   .function = tap_create_command_fn,
 };

src/vnet/devices/tap/tap.c

diff --git a/src/vnet/devices/tap/tap.c b/src/vnet/devices/tap/tap.c
index 77c15ce..040ec1f 100644
--- a/src/vnet/devices/tap/tap.c
+++ b/src/vnet/devices/tap/tap.c
@@ -731,7 +731,6 @@
   if ((args->tap_flags & TAP_FLAG_GSO)
       && (args->tap_flags & TAP_FLAG_GRO_COALESCE))
     {
-      vif->packet_coalesce = 1;
       virtio_set_packet_coalesce (vif);
     }
   vnet_hw_interface_set_input_node (vnm, vif->hw_if_index,
@@ -900,7 +899,6 @@
 	}
       if (is_packet_coalesce)
 	{
-	  vif->packet_coalesce = 1;
 	  virtio_set_packet_coalesce (vif);
 	}
     }