commit 178cf493d009995b28fdf220f04c98860ff79a9b
author Dave Barach <dave@barachs.net> Tue Nov 13 16:34:13 2018 -0500
committer Florin Coras <florin.coras@gmail.com> Wed Nov 14 15:54:01 2018 +0000
tree 097c1be82b8f6fa9bc04b9b1e193158e2e4997eb
parent 6917b94f2146aa51195a6a2a1ccd8416a1d74bf3

Remove c-11 memcpy checks from perf-critical code

Change-Id: Id4f37f5d4a03160572954a416efa1ef9b3d79ad1
Signed-off-by: Dave Barach <dave@barachs.net>

src/vnet/tcp/tcp_output.c

diff --git a/src/vnet/tcp/tcp_output.c b/src/vnet/tcp/tcp_output.c
index 4915636..2068e43 100644
--- a/src/vnet/tcp/tcp_output.c
+++ b/src/vnet/tcp/tcp_output.c
@@ -215,7 +215,7 @@
       *data++ = TCP_OPTION_MSS;
       *data++ = TCP_OPTION_LEN_MSS;
       buf = clib_host_to_net_u16 (opts->mss);
-      clib_memcpy (data, &buf, sizeof (opts->mss));
+      clib_memcpy_fast (data, &buf, sizeof (opts->mss));
       data += sizeof (opts->mss);
       opts_len += TCP_OPTION_LEN_MSS;
     }
@@ -240,10 +240,10 @@
       *data++ = TCP_OPTION_TIMESTAMP;
       *data++ = TCP_OPTION_LEN_TIMESTAMP;
       buf = clib_host_to_net_u32 (opts->tsval);
-      clib_memcpy (data, &buf, sizeof (opts->tsval));
+      clib_memcpy_fast (data, &buf, sizeof (opts->tsval));
       data += sizeof (opts->tsval);
       buf = clib_host_to_net_u32 (opts->tsecr);
-      clib_memcpy (data, &buf, sizeof (opts->tsecr));
+      clib_memcpy_fast (data, &buf, sizeof (opts->tsecr));
       data += sizeof (opts->tsecr);
       opts_len += TCP_OPTION_LEN_TIMESTAMP;
     }
@@ -261,10 +261,10 @@
 	  for (i = 0; i < n_sack_blocks; i++)
 	    {
 	      buf = clib_host_to_net_u32 (opts->sacks[i].start);
-	      clib_memcpy (data, &buf, seq_len);
+	      clib_memcpy_fast (data, &buf, seq_len);
 	      data += seq_len;
 	      buf = clib_host_to_net_u32 (opts->sacks[i].end);
-	      clib_memcpy (data, &buf, seq_len);
+	      clib_memcpy_fast (data, &buf, seq_len);
 	      data += seq_len;
 	    }
 	  opts_len += 2 + n_sack_blocks * TCP_OPTION_LEN_SACK_BLOCK;
@@ -764,8 +764,8 @@
     {
       ih6 = vlib_buffer_get_current (b0);
       ASSERT ((ih6->ip_version_traffic_class_and_flow_label & 0xF0) == 0x60);
-      clib_memcpy (&src_ip60, &ih6->src_address, sizeof (ip6_address_t));
-      clib_memcpy (&dst_ip60, &ih6->dst_address, sizeof (ip6_address_t));
+      clib_memcpy_fast (&src_ip60, &ih6->src_address, sizeof (ip6_address_t));
+      clib_memcpy_fast (&dst_ip60, &ih6->dst_address, sizeof (ip6_address_t));
     }
 
   src_port = th0->src_port;
@@ -1175,9 +1175,9 @@
 
   if (maybe_burst)
     {
-      clib_memcpy ((u8 *) (th + 1),
-		   tm->wrk_ctx[tc->c_thread_index].cached_opts,
-		   tc->snd_opts_len);
+      clib_memcpy_fast ((u8 *) (th + 1),
+			tm->wrk_ctx[tc->c_thread_index].cached_opts,
+			tc->snd_opts_len);
     }
   else
     {
@@ -2058,8 +2058,8 @@
       tc = tcp_connection_get (vnet_buffer (b)->tcp.connection_index,
 			       vm->thread_index);
       t = vlib_add_trace (vm, node, b, sizeof (*t));
-      clib_memcpy (&t->tcp_header, th, sizeof (t->tcp_header));
-      clib_memcpy (&t->tcp_connection, tc, sizeof (t->tcp_connection));
+      clib_memcpy_fast (&t->tcp_header, th, sizeof (t->tcp_header));
+      clib_memcpy_fast (&t->tcp_connection, tc, sizeof (t->tcp_connection));
     }
 }
 
@@ -2322,7 +2322,8 @@
 	      else
 		th0 = ip6_next_header ((ip6_header_t *) th0);
 	      t0 = vlib_add_trace (vm, node, b0, sizeof (*t0));
-	      clib_memcpy (&t0->tcp_header, th0, sizeof (t0->tcp_header));
+	      clib_memcpy_fast (&t0->tcp_header, th0,
+				sizeof (t0->tcp_header));
 	    }
 
 	  vlib_validate_buffer_enqueue_x1 (vm, node, next_index, to_next,