commit 19296116be4754e43751399e25f5206cafc70c1f
author Dave Wallace <dwallacelf@gmail.com> Thu Aug 31 15:54:11 2017 -0400
committer Florin Coras <florin.coras@gmail.com> Wed Sep 06 22:35:52 2017 +0000
tree 0ae1ef925398cab98a8d910d94776db38e0ec6fd
parent 91f3e744a37b9f6f3c87ac45e54142f16fd2d3d5

Set uid/gid on ssvm segment file.

Change-Id: I482bb9654f4dfe240bace5c2b61056cfd04cf018
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

src/svm/ssvm.c

diff --git a/src/svm/ssvm.c b/src/svm/ssvm.c
index e56e6b4..c04982d 100644
--- a/src/svm/ssvm.c
+++ b/src/svm/ssvm.c
@@ -13,10 +13,12 @@
  * limitations under the License.
  */
 #include "ssvm.h"
+#include "svm_common.h"
 
 int
 ssvm_master_init (ssvm_private_t * ssvm, u32 master_index)
 {
+  svm_main_region_t *smr = svm_get_root_rp ()->data_base;
   int ssvm_fd;
   u8 *ssvm_filename;
   u8 junk = 0;
@@ -47,6 +49,11 @@
       return SSVM_API_ERROR_CREATE_FAILURE;
     }
 
+  if (fchmod (ssvm_fd, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP) < 0)
+    clib_unix_warning ("ssvm segment chmod");
+  if (fchown (ssvm_fd, smr->uid, smr->gid) < 0)
+    clib_unix_warning ("ssvm segment chown");
+
   if (lseek (ssvm_fd, ssvm->ssvm_size, SEEK_SET) < 0)
     {
       clib_unix_warning ("lseek");

src/svm/svm.c

diff --git a/src/svm/svm.c b/src/svm/svm.c
index 14c5bd9..f97803c 100644
--- a/src/svm/svm.c
+++ b/src/svm/svm.c
@@ -471,7 +471,7 @@
 
   if (svm_fd >= 0)
     {
-      if (fchmod (svm_fd, 0770) < 0)
+      if (fchmod (svm_fd, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP) < 0)
 	clib_unix_warning ("segment chmod");
       /* This turns out to fail harmlessly if the client starts first */
       if (fchown (svm_fd, a->uid, a->gid) < 0)
@@ -774,6 +774,8 @@
       vec_validate (mp, 0);
       mp->name_hash = hash_create_string (0, sizeof (uword));
       mp->root_path = a->root_path ? format (0, "%s%c", a->root_path, 0) : 0;
+      mp->uid = a->uid;
+      mp->gid = a->gid;
       rp->data_base = mp;
       svm_pop_heap (oldheap);
     }

src/svm/svm_common.h

diff --git a/src/svm/svm_common.h b/src/svm/svm_common.h
index 1f6d83c..ea3ec87 100644
--- a/src/svm/svm_common.h
+++ b/src/svm/svm_common.h
@@ -105,6 +105,8 @@
   svm_subregion_t *subregions;	/* subregion pool */
   uword *name_hash;
   u8 *root_path;
+  int uid;
+  int gid;
 } svm_main_region_t;