commit 30684ac044bbb8e11ef100a24c01eb37ba7a8876
author Chris Luke <chrisy@flirble.org> Thu Mar 29 12:56:58 2018 -0700
committer Chris Luke <chrisy@flirble.org> Thu Mar 29 15:23:56 2018 -0700
tree ac5d526793fbafed606355c22d8e627e66d95786
parent f3a3bad8006afb0b379761dfe4d5d25de07b32cc

Coverity fixes (VPP-1204)

Minor bug fixes

CID 183000: double close
CID 180996: dead code
CID 180995: NULL deref
CID 181957: NULL deref
CID 182676: NULL deref
CID 182675: NULL deref

Change-Id: Id35e391c95fafb8cd771984ee8a1a6e597056d37
Signed-off-by: Chris Luke <chrisy@flirble.org>

src/vlib/linux/pci.c

diff --git a/src/vlib/linux/pci.c b/src/vlib/linux/pci.c
index 127d2ef..11480ca 100644
--- a/src/vlib/linux/pci.c
+++ b/src/vlib/linux/pci.c
@@ -919,8 +919,9 @@
     {
       if (p->fd != -1)
 	close (p->fd);
-      if (p->config_fd != -1)
+      if (p->config_fd != -1 && p->config_fd != p->fd)
 	close (p->config_fd);
+      p->config_fd = p->fd = -1;
     }
   return err;
 }