commit 36d49391aadeb10b9f3626b62c5c019c4fddf5ed
author Florin Coras <fcoras@cisco.com> Fri Apr 24 23:00:11 2020 +0000
committer Dave Barach <openvpp@barachs.net> Sat Apr 25 11:40:25 2020 +0000
tree 9280b80a3769104f5ab3e8422428190a640c3352
parent 5e6222a0332e38316b5a58b23c35cca69bb72025

session vcl: propagate transport cleanup notifications

Type: improvement

Can be used to force app to close a connection on which it still waits
for data.

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I7c3a8245cbbc23728e4408feb63a659a11f718ed

src/vnet/session/session_api.c

diff --git a/src/vnet/session/session_api.c b/src/vnet/session/session_api.c
index 3954537..cfeb7bc 100644
--- a/src/vnet/session/session_api.c
+++ b/src/vnet/session/session_api.c
@@ -550,8 +550,9 @@
   session_event_t *evt;
   app_worker_t *app_wrk;
 
-  /* Only propagate session cleanup notification */
-  if (ntf == SESSION_CLEANUP_TRANSPORT)
+  /* Propagate transport cleanup notifications only if app didn't close */
+  if (ntf == SESSION_CLEANUP_TRANSPORT
+      && s->session_state != SESSION_STATE_TRANSPORT_DELETED)
     return;
 
   app_wrk = app_worker_get_if_valid (s->app_wrk_index);
@@ -567,6 +568,7 @@
   evt->event_type = SESSION_CTRL_EVT_CLEANUP;
   mp = (session_cleanup_msg_t *) evt->data;
   mp->handle = session_handle (s);
+  mp->type = ntf;
   svm_msg_q_add_and_unlock (app_mq, msg);
 }