commit 473556dcf13bd7e1d8165563ebe5cd97aa5e6c12
author Florin Coras <fcoras@cisco.com> Mon Nov 23 15:59:36 2020 -0800
committer Damjan Marion <dmarion@me.com> Tue Nov 24 10:22:08 2020 +0000
tree 06ab184a261b55bf6dcb542bee3adde50cc2548b
parent 5c2a23720f433aa5ddcc1b077ddb91f494ff958d

session: init lookup before dgram accept notification

Avoids potential session pointer invalidation

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ide9ba0ab732707d3dda6019ebb77f0b9489dfda7

src/vnet/session/session.c

diff --git a/src/vnet/session/session.c b/src/vnet/session/session.c
index 9429ddb..3a468b4 100644
--- a/src/vnet/session/session.c
+++ b/src/vnet/session/session.c
@@ -1158,16 +1158,18 @@
       return rv;
     }
 
+  session_lookup_add_connection (tc, session_handle (s));
+
   app_wrk = app_worker_get (s->app_wrk_index);
   if ((rv = app_worker_accept_notify (app_wrk, s)))
     {
+      session_lookup_del_session (s);
       segment_manager_dealloc_fifos (s->rx_fifo, s->tx_fifo);
       session_free (s);
       return rv;
     }
 
   s->session_state = SESSION_STATE_READY;
-  session_lookup_add_connection (tc, session_handle (s));
 
   return 0;
 }