Refactor fragile msg macro W and W2 to not burry return control flow.
Instead, have them accept and assign a return paramter leaving
the return control flow up to the caller. Clean up otherwise
misleading returns present even after "NOT REACHED" comments.
Change-Id: I0861921f73ab65d55b95eabd27514f0129152723
Signed-off-by: Jon Loeliger <jdl@netgate.com>
diff --git a/src/vlibapi/vat_helper_macros.h b/src/vlibapi/vat_helper_macros.h
index ffb74fe..5772233 100644
--- a/src/vlibapi/vat_helper_macros.h
+++ b/src/vlibapi/vat_helper_macros.h
@@ -42,32 +42,32 @@
#define S(mp) (vl_msg_api_send_shmem (vam->vl_input_queue, (u8 *)&mp))
/* W: wait for results, with timeout */
-#define W \
+#define W(ret) \
do { \
f64 timeout = vat_time_now (vam) + 1.0; \
\
while (vat_time_now (vam) < timeout) { \
if (vam->result_ready == 1) { \
- return (vam->retval); \
+ ret = vam->retval; \
} \
vat_suspend (vam->vlib_main, 1e-5); \
} \
- return -99; \
+ ret = -99; \
} while(0);
/* W2: wait for results, with timeout */
-#define W2(body) \
+#define W2(ret, body) \
do { \
f64 timeout = vat_time_now (vam) + 1.0; \
\
while (vat_time_now (vam) < timeout) { \
if (vam->result_ready == 1) { \
(body); \
- return (vam->retval); \
+ ret = vam->retval; \
} \
vat_suspend (vam->vlib_main, 1e-5); \
} \
- return -99; \
+ ret = -99; \
} while(0);