commit 5943e36b60955ff7baaac383dcd121e36c999711
author Benoît Ganne <bganne@cisco.com> Fri Feb 26 14:46:58 2021 +0100
committer Dave Barach <openvpp@barachs.net> Tue Mar 02 12:59:55 2021 +0000
tree 99913db859d4ea82ebb1d93bf14496f840660ead
parent 8c45e5109522cf9bbc98785283cd4c923f486fe6

classify: fix crash if no pcap filter has been configured

If no pcap filters have ever been configured and we try to enable pcap
capture with a filter, cm->classify_table_index_by_sw_if_index is not
initialized yet.

Type: fix

Change-Id: I2f509c58f9984951b1ad81c1c8ed912cb594fce1
Signed-off-by: Benoît Ganne <bganne@cisco.com>

src/vnet/interface_cli.c

diff --git a/src/vnet/interface_cli.c b/src/vnet/interface_cli.c
index a901e17..54e0673 100644
--- a/src/vnet/interface_cli.c
+++ b/src/vnet/interface_cli.c
@@ -1971,7 +1971,8 @@
 
   /* Classify filter specified, but no classify filter configured */
   if ((a->rx_enable + a->tx_enable + a->drop_enable) && a->filter &&
-      cm->classify_table_index_by_sw_if_index[0] == ~0)
+      (!cm->classify_table_index_by_sw_if_index ||
+       cm->classify_table_index_by_sw_if_index[0] == ~0))
     return VNET_API_ERROR_NO_SUCH_LABEL;
 
   if (a->rx_enable + a->tx_enable + a->drop_enable)