commit 61e63bf4e14eddebdd99814cf2633c2e638cd21c
author Paul Vinciguerra <pvinci@vinciconsulting.com> Sat Nov 24 21:19:38 2018 -0800
committer Ole Trøan <otroan@employees.org> Sun Nov 25 18:33:50 2018 +0000
tree bf1e33a58f38deb7628a5df94202b9b30c61c621
parent c2b4dc598149e9aa2e1727259257b2650f95c683

make test: Fix too wide subprocess exceptions

When a command fails, CalledProcessError is raised. testing with except: masks other failures.

Change-Id: I7e3a6739411cb6a4c13e96dd123aff9159213fea
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

test/framework.py

diff --git a/test/framework.py b/test/framework.py
index 3c4aacb..c29346b 100644
--- a/test/framework.py
+++ b/test/framework.py
@@ -348,7 +348,7 @@
                                        stdout=subprocess.PIPE,
                                        stderr=subprocess.PIPE,
                                        bufsize=1)
-        except Exception as e:
+        except subprocess.CalledProcessError as e:
             cls.logger.critical("Couldn't start vpp: %s" % e)
             raise