commit 63777e599af8df1e6bf8c564c638d52007af47d0
author Marco Varlese <marco.varlese@suse.com> Wed Apr 18 08:50:57 2018 +0200
committer Neale Ranns <nranns@cisco.com> Wed Apr 18 10:55:37 2018 +0000
tree 9037dbe35d5a2b72df8069a5baeaad2e7f01da91
parent 7fb0fe1f6972a7a35146fa9115b866ba29a6fbb7

SCTP: coverity warnings

This patch addresses the warning 182994

Change-Id: I071f3cbdf9965c7b57d444f79430ee75c66c856e
Signed-off-by: Marco Varlese <marco.varlese@suse.com>

src/vnet/sctp/sctp_input.c

diff --git a/src/vnet/sctp/sctp_input.c b/src/vnet/sctp/sctp_input.c
index 7c753a2..ff79840 100644
--- a/src/vnet/sctp/sctp_input.c
+++ b/src/vnet/sctp/sctp_input.c
@@ -492,7 +492,6 @@
 {
   sctp_init_ack_chunk_t *init_ack_chunk =
     (sctp_init_ack_chunk_t *) (sctp_hdr);
-  sctp_state_cookie_param_t state_cookie;
 
   char hostname[FQDN_MAX_LENGTH];
 
@@ -569,8 +568,9 @@
 		sctp_state_cookie_param_t *state_cookie_param =
 		  (sctp_state_cookie_param_t *) opt_params_hdr;
 
-		clib_memcpy (&state_cookie, state_cookie_param,
+		clib_memcpy (&(sctp_conn->cookie_param), state_cookie_param,
 			     sizeof (sctp_state_cookie_param_t));
+
 		break;
 	      }
 	    case SCTP_HOSTNAME_ADDRESS_TYPE:
@@ -596,9 +596,6 @@
 	}
     }
 
-  clib_memcpy (&(sctp_conn->cookie_param), &state_cookie,
-	       sizeof (sctp_state_cookie_param_t));
-
   sctp_prepare_cookie_echo_chunk (sctp_conn, idx, b0, 1);
 
   /* Start the T1_COOKIE timer */