commit 6e43e0680fc21c6a986289cec4406c3624d3bbe6
author Neale Ranns <nranns@cisco.com> Fri Oct 26 05:17:03 2018 -0700
committer Damjan Marion <dmarion@me.com> Sat Oct 27 09:06:06 2018 +0000
tree 8cf2c1340739e8e6f08da2bc0ee70e22eca5a96d
parent f9dafebc44c7b52605eed393a418f47ca3ce6990

Enumify interface flags

clang will emit a warning when the wrong enum type is passed to a
function whose arguments are an enum type. free bug finding...

Change-Id: I62215d8ef22c7527a31272e31f5d190e4e762e53
Signed-off-by: Neale Ranns <nranns@cisco.com>

src/vnet/interface.c

diff --git a/src/vnet/interface.c b/src/vnet/interface.c
index dba5a66..dff1793 100644
--- a/src/vnet/interface.c
+++ b/src/vnet/interface.c
@@ -44,18 +44,25 @@
 #include <vnet/adj/adj_mcast.h>
 #include <vnet/l2/l2_input.h>
 
-#define VNET_INTERFACE_SET_FLAGS_HELPER_IS_CREATE (1 << 0)
-#define VNET_INTERFACE_SET_FLAGS_HELPER_WANT_REDISTRIBUTE (1 << 1)
+typedef enum vnet_interface_helper_flags_t_
+{
+  VNET_INTERFACE_SET_FLAGS_HELPER_IS_CREATE = (1 << 0),
+  VNET_INTERFACE_SET_FLAGS_HELPER_WANT_REDISTRIBUTE = (1 << 1),
+} vnet_interface_helper_flags_t;
 
 static clib_error_t *vnet_hw_interface_set_flags_helper (vnet_main_t * vnm,
 							 u32 hw_if_index,
-							 u32 flags,
-							 u32 helper_flags);
+							 vnet_hw_interface_flags_t
+							 flags,
+							 vnet_interface_helper_flags_t
+							 helper_flags);
 
 static clib_error_t *vnet_sw_interface_set_flags_helper (vnet_main_t * vnm,
 							 u32 sw_if_index,
-							 u32 flags,
-							 u32 helper_flags);
+							 vnet_sw_interface_flags_t
+							 flags,
+							 vnet_interface_helper_flags_t
+							 helper_flags);
 
 static clib_error_t *vnet_hw_interface_set_class_helper (vnet_main_t * vnm,
 							 u32 hw_if_index,
@@ -260,7 +267,9 @@
 
 static clib_error_t *
 vnet_hw_interface_set_flags_helper (vnet_main_t * vnm, u32 hw_if_index,
-				    u32 flags, u32 helper_flags)
+				    vnet_hw_interface_flags_t flags,
+				    vnet_interface_helper_flags_t
+				    helper_flags)
 {
   vnet_hw_interface_t *hi = vnet_get_hw_interface (vnm, hw_if_index);
   vnet_hw_interface_class_t *hw_class =
@@ -308,7 +317,9 @@
 
 static clib_error_t *
 vnet_sw_interface_set_flags_helper (vnet_main_t * vnm, u32 sw_if_index,
-				    u32 flags, u32 helper_flags)
+				    vnet_sw_interface_flags_t flags,
+				    vnet_interface_helper_flags_t
+				    helper_flags)
 {
   vnet_sw_interface_t *si = vnet_get_sw_interface (vnm, sw_if_index);
   u32 mask;
@@ -466,7 +477,8 @@
 }
 
 clib_error_t *
-vnet_hw_interface_set_flags (vnet_main_t * vnm, u32 hw_if_index, u32 flags)
+vnet_hw_interface_set_flags (vnet_main_t * vnm, u32 hw_if_index,
+			     vnet_hw_interface_flags_t flags)
 {
   return vnet_hw_interface_set_flags_helper
     (vnm, hw_if_index, flags,
@@ -474,7 +486,8 @@
 }
 
 clib_error_t *
-vnet_sw_interface_set_flags (vnet_main_t * vnm, u32 sw_if_index, u32 flags)
+vnet_sw_interface_set_flags (vnet_main_t * vnm, u32 sw_if_index,
+			     vnet_sw_interface_flags_t flags)
 {
   return vnet_sw_interface_set_flags_helper
     (vnm, sw_if_index, flags,