commit 74b7437bd118e104f50831f8a8f3cc8d10aa2530
author Florin Coras <fcoras@cisco.com> Thu Mar 28 16:31:52 2019 -0700
committer Damjan Marion <dmarion@me.com> Fri Mar 29 09:31:48 2019 +0000
tree 84ca97893986dfffce6c36277bfd0ebb8f06d64f
parent d4bdd93f07b0acc15f84ec602532bc3dbab3c2bb

tcp: remove sent rcv wnd 0 flag

Change-Id: If6c672d1caa8884eb5d819311606a79a3de81200
Signed-off-by: Florin Coras <fcoras@cisco.com>

src/vnet/tcp/tcp.h

diff --git a/src/vnet/tcp/tcp.h b/src/vnet/tcp/tcp.h
index d9f49df..8383d01 100644
--- a/src/vnet/tcp/tcp.h
+++ b/src/vnet/tcp/tcp.h
@@ -117,7 +117,6 @@
 #define foreach_tcp_connection_flag             \
   _(SNDACK, "Send ACK")                         \
   _(FINSNT, "FIN sent")				\
-  _(SENT_RCV_WND0, "Sent 0 rcv_wnd")     	\
   _(RECOVERY, "Recovery")                    	\
   _(FAST_RECOVERY, "Fast Recovery")		\
   _(DCNT_PENDING, "Disconnect pending")		\

src/vnet/tcp/tcp_input.c

diff --git a/src/vnet/tcp/tcp_input.c b/src/vnet/tcp/tcp_input.c
index c27631f..cc630f8 100644
--- a/src/vnet/tcp/tcp_input.c
+++ b/src/vnet/tcp/tcp_input.c
@@ -1876,8 +1876,8 @@
 {
   /* Send ack if ... */
   if (TCP_ALWAYS_ACK
-      /* just sent a rcv wnd 0 */
-      || (tc->flags & TCP_CONN_SENT_RCV_WND0) != 0
+      /* just sent a rcv wnd 0
+         || (tc->flags & TCP_CONN_SENT_RCV_WND0) != 0 */
       /* constrained to send ack */
       || (tc->flags & TCP_CONN_SNDACK) != 0
       /* we're almost out of tx wnd */

src/vnet/tcp/tcp_output.c

diff --git a/src/vnet/tcp/tcp_output.c b/src/vnet/tcp/tcp_output.c
index b1e848c..518a80d 100644
--- a/src/vnet/tcp/tcp_output.c
+++ b/src/vnet/tcp/tcp_output.c
@@ -183,16 +183,6 @@
     return tcp_initial_window_to_advertise (tc);
 
   tcp_update_rcv_wnd (tc);
-
-  if (tc->rcv_wnd == 0)
-    {
-      tc->flags |= TCP_CONN_SENT_RCV_WND0;
-    }
-  else
-    {
-      tc->flags &= ~TCP_CONN_SENT_RCV_WND0;
-    }
-
   return tc->rcv_wnd >> tc->rcv_wscale;
 }