commit 78053e164fbb75c014126a3deff440f165504582
author Pavel Kotucek <pkotucek@cisco.com> Fri Mar 10 10:03:59 2017 +0100
committer Ole Trøan <otroan@employees.org> Fri Mar 10 11:32:24 2017 +0000
tree 441cbb7e9caecfe3227297ae9e4929a78881a615
parent b69259a55d6ae4a0133eaa725edfea246d905f8b

Fix coverity CIDs 161048, 163895

Change-Id: Ic206601413bb366e2a920daf00524e92a47287ef
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>

src/vnet/ipsec/ipsec_api.c

diff --git a/src/vnet/ipsec/ipsec_api.c b/src/vnet/ipsec/ipsec_api.c
index e37bcce..9c4ba52 100644
--- a/src/vnet/ipsec/ipsec_api.c
+++ b/src/vnet/ipsec/ipsec_api.c
@@ -209,8 +209,7 @@
   sa.crypto_key_len = mp->crypto_key_length;
   clib_memcpy (&sa.crypto_key, mp->crypto_key, sizeof (sa.crypto_key));
   /* check for unsupported integ-alg */
-  if (mp->integrity_algorithm < IPSEC_INTEG_ALG_NONE ||
-      mp->integrity_algorithm >= IPSEC_INTEG_N_ALG)
+  if (mp->integrity_algorithm >= IPSEC_INTEG_N_ALG)
     {
       clib_warning ("unsupported integ-alg: '%U'", format_ipsec_integ_alg,
 		    mp->integrity_algorithm);

src/vnet/span/node.c

diff --git a/src/vnet/span/node.c b/src/vnet/span/node.c
index eb69c39..2a43b6e 100644
--- a/src/vnet/span/node.c
+++ b/src/vnet/span/node.c
@@ -69,8 +69,6 @@
   u32 i;
 
   si0 = vec_elt_at_index (sm->interfaces, sw_if_index0);
-  if (!si0)
-    return;
 
   if (is_rx != 0 && si0->num_rx_mirror_ports == 0)
     return;