commit 8124cb784050275372e05a97b1e62f9f1ba5a091
author Florin Coras <fcoras@cisco.com> Sun Dec 16 20:57:29 2018 -0800
committer Florin Coras <florin.coras@gmail.com> Mon Dec 17 18:51:19 2018 +0000
tree fea3fc4fa4fea1517f482c949e16175d3f902d52
parent 91236ce0117fe5662b106b54824c84e44bfd7a2d

tcp: fix handling of broken syn options

Change-Id: Ia8b2a077ba4897ddd15cf33221b191cd7a3f1d33
Signed-off-by: Florin Coras <fcoras@cisco.com>

src/vnet/tcp/tcp_input.c

diff --git a/src/vnet/tcp/tcp_input.c b/src/vnet/tcp/tcp_input.c
index 4406d68..f0ae8b1 100644
--- a/src/vnet/tcp/tcp_input.c
+++ b/src/vnet/tcp/tcp_input.c
@@ -3097,7 +3097,7 @@
 	}
 
       /* Create child session and send SYN-ACK */
-      child0 = tcp_connection_new (my_thread_index);
+      child0 = tcp_connection_alloc (my_thread_index);
       child0->c_lcl_port = th0->dst_port;
       child0->c_rmt_port = th0->src_port;
       child0->c_is_ip4 = is_ip4;
@@ -3119,7 +3119,8 @@
 
       if (tcp_options_parse (th0, &child0->rcv_opts, 1))
 	{
-	  clib_warning ("options parse fail");
+	  error0 = TCP_ERROR_OPTIONS;
+	  tcp_connection_free (child0);
 	  goto drop;
 	}