commit 815c6a4fbcbb636ce3b4dc98446ad205a30670a6
author Piotr Bronowski <piotrx.bronowski@intel.com> Thu Jun 09 09:09:28 2022 +0000
committer Fan Zhang <roy.fan.zhang@intel.com> Tue Jun 28 14:53:07 2022 +0000
tree 36e3b6aec51cdd5603dce1c9dd701da869c11c39
parent 5b4b4c05ff06b866b90b0df9b2be2ed28e606f16

ipsec: change wildcard value for any protocol of spd policy

Currently 0 has been used as the wildcard representing ANY type of
protocol. However 0 is valid value of ip protocol (HOPOPT) and therefore
it should not be used as a wildcard. Instead 255 is used which is
guaranteed by IANA to be reserved and not used as a protocol id.

Type: improvement
Signed-off-by: Piotr Bronowski <piotrx.bronowski@intel.com>
Change-Id: I2320bae6fe380cb999dc5a9187beb68fda2d31eb

test/test_ipsec_nat.py

diff --git a/test/test_ipsec_nat.py b/test/test_ipsec_nat.py
index 64a2725..881b5a7 100644
--- a/test/test_ipsec_nat.py
+++ b/test/test_ipsec_nat.py
@@ -275,7 +275,7 @@
             self.tun_if.remote_addr[addr_type],
             self.pg1.remote_addr[addr_type],
             self.pg1.remote_addr[addr_type],
-            0,
+            socket.IPPROTO_RAW,
             priority=10,
             policy=e.IPSEC_API_SPD_ACTION_PROTECT,
             is_outbound=0,
@@ -288,7 +288,7 @@
             self.pg1.remote_addr[addr_type],
             self.tun_if.remote_addr[addr_type],
             self.tun_if.remote_addr[addr_type],
-            0,
+            socket.IPPROTO_RAW,
             policy=e.IPSEC_API_SPD_ACTION_PROTECT,
             priority=10,
         ).add_vpp_config()