commit 8181727ee518d46ac2f45b769e273431211257a6
author varasteh <mahdy.varasteh@gmail.com> Sun Jan 02 14:20:32 2022 +0330
committer Damjan Marion <dmarion@0xa5.net> Mon Mar 06 17:39:33 2023 +0000
tree 00d5cebc338ab08e41adb23da0fa6dd400fdf0dd
parent 88d9414e82e2106066047d58c5f0865f3df22ea3

interface: more cleaning after set flags is failed in vnet_create_sw_interface

There's a chance that vnet_sw_interface_set_flags_helper()
has successfully called some sw interface add callback functions
before returning the error. So the sw interface del callbacks
should also be called

Type: fix

Signed-off-by: varasteh <mahdy.varasteh@gmail.com>
Change-Id: I2cd7dc6d5b3a5ebfd2c4d1a6be5390083dee6401
Signed-off-by: varasteh <mahdy.varasteh@gmail.com>

src/vnet/interface.c

diff --git a/src/vnet/interface.c b/src/vnet/interface.c
index dd43998..18ce6b6 100644
--- a/src/vnet/interface.c
+++ b/src/vnet/interface.c
@@ -655,6 +655,7 @@
       /* undo the work done by vnet_create_sw_interface_no_callbacks() */
       log_err ("create_sw_interface: set flags failed\n  %U",
 	       format_clib_error, error);
+      call_sw_interface_add_del_callbacks (vnm, *sw_if_index, 0);
       vnet_sw_interface_t *sw =
 	pool_elt_at_index (im->sw_interfaces, *sw_if_index);
       pool_put (im->sw_interfaces, sw);