commit 8b276df32f0c833b31f8a5c8408855afbbde1307
author Neale Ranns <nranns@cisco.com> Mon Nov 09 10:13:24 2020 +0000
committer Matthew Smith <mgsmith@netgate.com> Thu Nov 19 21:56:49 2020 +0000
tree 4690d6bdd25372205436e7e04369a7e630ac5408
parent 4a98cf9648bc6852be9ba6622dc633f2168a7f66

ipip: Don't crash when showing non-existant tunnel index

Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I9717d420e42098e291c5b6c7d18e935ad78fdc3d

src/vnet/ipip/ipip_cli.c

diff --git a/src/vnet/ipip/ipip_cli.c b/src/vnet/ipip/ipip_cli.c
index 510806b..231c7e3 100644
--- a/src/vnet/ipip/ipip_cli.c
+++ b/src/vnet/ipip/ipip_cli.c
@@ -232,6 +232,8 @@
                  ({vlib_cli_output(vm, "%U", format_ipip_tunnel, t); }));
     /* *INDENT-ON* */
   } else {
+    if (pool_is_free_index (gm->tunnels, ti))
+        return clib_error_return(0, "unknown index:%d", ti);
     t = pool_elt_at_index(gm->tunnels, ti);
     if (t)
       vlib_cli_output(vm, "%U", format_ipip_tunnel, t);