commit 8c79a4ebb1f349b9bf1058c2e0511c0ea75b8552
author Florin Coras <fcoras@cisco.com> Tue Feb 25 22:28:27 2020 +0000
committer Dave Barach <openvpp@barachs.net> Wed Feb 26 15:28:45 2020 +0000
tree 3a7f286b74aabcda89dbbbf48bf92d30a10686d6
parent eb89b9093bc5c7b0b1511cf3d59454e15f9e4d92

svm: fix coverity warnings

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2d5cb7cccb67a3193ce5a25323e70bc05737e023

src/svm/fifo_segment.c

diff --git a/src/svm/fifo_segment.c b/src/svm/fifo_segment.c
index ec6f082..e19113f 100644
--- a/src/svm/fifo_segment.c
+++ b/src/svm/fifo_segment.c
@@ -75,7 +75,6 @@
 fsh_n_cached_bytes (fifo_segment_header_t * fsh)
 {
   uword n_cached = clib_atomic_load_relax_n (&fsh->n_cached_bytes);
-  ASSERT (n_cached >= 0);
   return n_cached;
 }
 

src/vnet/session/segment_manager.c

diff --git a/src/vnet/session/segment_manager.c b/src/vnet/session/segment_manager.c
index db38097..cbd4443 100644
--- a/src/vnet/session/segment_manager.c
+++ b/src/vnet/session/segment_manager.c
@@ -981,8 +981,7 @@
 segment_manager_set_watermarks (segment_manager_t * sm,
 				u8 high_watermark, u8 low_watermark)
 {
-  ASSERT (high_watermark >= 0 && high_watermark <= 100 &&
-	  low_watermark >= 0 && low_watermark <= 100 &&
+  ASSERT (high_watermark <= 100 && low_watermark <= 100 &&
 	  low_watermark <= high_watermark);
 
   sm->high_watermark = high_watermark;