commit 93dd58c8fb020870c770c2a4aa55dcc288fa2035
author Florin Coras <fcoras@cisco.com> Sun Jan 09 17:20:28 2022 -0800
committer Florin Coras <florin.coras@gmail.com> Mon Jan 10 03:07:44 2022 +0000
tree 49c23f22013b61a7d4e0c6f1f032b2377dcc7441
parent 26ea3ede43b9eb157a97850c70be3016040bd025

session: fix pacer bucket update cast

Make sure comparison is done between two i64 values.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ief5706f2bd9415587994a5b665d5e380b8e14f68

src/vnet/session/transport.c

diff --git a/src/vnet/session/transport.c b/src/vnet/session/transport.c
index 4b263cd..e4d84a3 100644
--- a/src/vnet/session/transport.c
+++ b/src/vnet/session/transport.c
@@ -660,12 +660,12 @@
 spacer_max_burst (spacer_t * pacer, clib_us_time_t time_now)
 {
   u64 n_periods = (time_now - pacer->last_update);
-  u64 inc;
+  i64 inc;
 
   if ((inc = (f32) n_periods * pacer->tokens_per_period) > 10)
     {
       pacer->last_update = time_now;
-      pacer->bucket = clib_min (pacer->bucket + inc, pacer->max_burst);
+      pacer->bucket = clib_min (pacer->bucket + inc, (i64) pacer->max_burst);
     }
 
   return pacer->bucket > 0 ? pacer->max_burst : 0;