commit b14826e459302556febb391456ea90644278645a
author John Lo <loj@cisco.com> Wed Apr 18 15:52:23 2018 -0400
committer Damjan Marion <dmarion.lists@gmail.com> Thu Apr 19 09:21:26 2018 +0000
tree 8d3c8e1ae9c6a4021e58b39589b35d501ef81165
parent 5b6ae8de4fd0d7855f8f38426dd4524ebcb15fee

Minor optimzation/cleanup to ethernet-input node

Change-Id: Ibf3ef82950f50b746394a731cd2e7cba1cd16ec4
Signed-off-by: John Lo <loj@cisco.com>

src/vnet/ethernet/node.c

diff --git a/src/vnet/ethernet/node.c b/src/vnet/ethernet/node.c
index d13af57..55d8285 100755
--- a/src/vnet/ethernet/node.c
+++ b/src/vnet/ethernet/node.c
@@ -229,8 +229,6 @@
 		     u32 is_l20,
 		     u32 type0, vlib_buffer_t * b0, u8 * error0, u8 * next0)
 {
-  u32 eth_start = vnet_buffer (b0)->l2_hdr_offset;
-  vnet_buffer (b0)->l2.l2_len = b0->current_data - eth_start;
   if (PREDICT_FALSE (*error0 != ETHERNET_ERROR_NONE))
     {
       // some error occurred
@@ -238,8 +236,10 @@
     }
   else if (is_l20)
     {
-      *next0 = em->l2_next;
       // record the L2 len and reset the buffer so the L2 header is preserved
+      u32 eth_start = vnet_buffer (b0)->l2_hdr_offset;
+      vnet_buffer (b0)->l2.l2_len = b0->current_data - eth_start;
+      *next0 = em->l2_next;
       ASSERT (vnet_buffer (b0)->l2.l2_len ==
 	      ethernet_buffer_header_size (b0));
       vlib_buffer_advance (b0, -ethernet_buffer_header_size (b0));
@@ -430,12 +430,12 @@
 		      (hi->hw_address != 0) &&
 		      !eth_mac_equal ((u8 *) e1, hi->hw_address))
 		    error1 = ETHERNET_ERROR_L3_MAC_MISMATCH;
+		  vlib_buffer_advance (b0, sizeof (ethernet_header_t));
 		  determine_next_node (em, variant, 0, type0, b0,
 				       &error0, &next0);
-		  vlib_buffer_advance (b0, sizeof (ethernet_header_t));
+		  vlib_buffer_advance (b1, sizeof (ethernet_header_t));
 		  determine_next_node (em, variant, 0, type1, b1,
 				       &error1, &next1);
-		  vlib_buffer_advance (b1, sizeof (ethernet_header_t));
 		}
 	      goto ship_it01;
 	    }