devices: fix coverity warning/don't leak fd
Move socket creation past code which returns from function to avoid
leaking the socket in case of an early error return.
Type: fix
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I9e18bd32022441c17ca920d1c2458b058b76c3c0
diff --git a/src/vnet/devices/af_packet/device.c b/src/vnet/devices/af_packet/device.c
index 8e4bc2b..c8e59c3 100644
--- a/src/vnet/devices/af_packet/device.c
+++ b/src/vnet/devices/af_packet/device.c
@@ -336,7 +336,7 @@
af_packet_main_t *apm = &af_packet_main;
af_packet_if_t *apif =
pool_elt_at_index (apm->interfaces, hi->dev_instance);
- int rv, fd = socket (AF_UNIX, SOCK_DGRAM, 0);
+ int rv, fd;
struct ifreq ifr;
if (apif->mode == AF_PACKET_IF_MODE_IP)
@@ -347,6 +347,7 @@
" MAC update failed, interface is in IP mode");
}
+ fd = socket (AF_UNIX, SOCK_DGRAM, 0);
if (0 > fd)
{
vlib_log_warn (apm->log_class, "af_packet_%s could not open socket",