commit c5b0fcd159d471f0422b303a2efa5ba6e8ddfcd6
author Benoît Ganne <bganne@cisco.com> Thu Dec 22 15:01:32 2022 +0100
committer Florin Coras <florin.coras@gmail.com> Fri Dec 23 17:18:53 2022 +0000
tree df43592fa4aec20ddf0eaaf7db229e78042e5968
parent b89db0cf75a5fe2768b7ef53fac2efb8c4b84ca0

hsa: fix echo client workers initialization

We were creating an additional worker not backed by any VPP threads,
leading off-by-1 access in the session main workers vector.
Also uses vec_elt_at_index() when accessing session main workers vector
elements to catch those errors more easily.

Type: fix

Change-Id: I6059116b7b64ae6b26ad83c1fcf55df8522868ad
Signed-off-by: Benoît Ganne <bganne@cisco.com>

src/vnet/session/session.h

diff --git a/src/vnet/session/session.h b/src/vnet/session/session.h
index b8cc1c3..ab92295 100644
--- a/src/vnet/session/session.h
+++ b/src/vnet/session/session.h
@@ -709,7 +709,7 @@
 always_inline session_worker_t *
 session_main_get_worker (u32 thread_index)
 {
-  return &session_main.wrk[thread_index];
+  return vec_elt_at_index (session_main.wrk, thread_index);
 }
 
 static inline session_worker_t *
@@ -717,13 +717,13 @@
 {
   if (thread_index > vec_len (session_main.wrk))
     return 0;
-  return &session_main.wrk[thread_index];
+  return session_main_get_worker (thread_index);
 }
 
 always_inline svm_msg_q_t *
 session_main_get_vpp_event_queue (u32 thread_index)
 {
-  return session_main.wrk[thread_index].vpp_event_queue;
+  return session_main_get_worker (thread_index)->vpp_event_queue;
 }
 
 always_inline u8