commit c62a83daeac52c8642206ac1660e4e3e6ead77bf
author Dave Barach <dave@barachs.net> Thu Aug 01 16:08:13 2019 -0400
committer Andrew Yourtchenko <ayourtch@gmail.com> Fri Aug 02 14:14:03 2019 +0000
tree 99a4e09615a9ce28a448c9970a72d29f5866bd41
parent 678d64d0b28f9ea1728ff35ae162c8f22d1cb8a9

ethernet: fix ARP feature arc definition

This patch gets rid of an ugly warning during vpp startup:

"vnet_feature_init:143: WARNING: arp arc: last node is arp-disabled,
but expected error-drop!"

Type: fix
Fixes: 1ff56f00ca015e82ef29955986e503913d1c3b86

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I80914a3c113c090a09bd5a5131e39f036871d92e

src/vnet/ethernet/arp.c

diff --git a/src/vnet/ethernet/arp.c b/src/vnet/ethernet/arp.c
index 86ad9f3..a42cfda 100644
--- a/src/vnet/ethernet/arp.c
+++ b/src/vnet/ethernet/arp.c
@@ -1711,7 +1711,7 @@
 {
   .arc_name = "arp",
   .start_nodes = VNET_FEATURES ("arp-input"),
-  .last_in_arc = "error-drop",
+  .last_in_arc = "arp-disabled",
   .arc_index_ptr = &ethernet_arp_main.feature_arc_index,
 };
 
@@ -1730,10 +1730,17 @@
   .runs_before = VNET_FEATURES ("arp-disabled"),
 };
 
-VNET_FEATURE_INIT (arp_drop_feat_node, static) =
+VNET_FEATURE_INIT (arp_disabled_feat_node, static) =
 {
   .arc_name = "arp",
   .node_name = "arp-disabled",
+  .runs_before = VNET_FEATURES ("error-drop"),
+};
+
+VNET_FEATURE_INIT (arp_drop_feat_node, static) =
+{
+  .arc_name = "arp",
+  .node_name = "error-drop",
   .runs_before = 0,	/* last feature */
 };