commit cf0e257dcf3d23a3b38129e1a3375f1c38c10973
author Florin Coras <fcoras@cisco.com> Wed Apr 14 17:55:02 2021 -0700
committer Dave Barach <openvpp@barachs.net> Thu Apr 15 16:38:02 2021 +0000
tree 2db056a40efb864b136de00e54f7452e966387c0
parent 0e79bc14babb282f8ba0dca2237209da80be6317

vcl: validate fs before cleanup

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I1d3677923ab28325380c4a9e8469da83077262a9

src/vcl/vcl_private.c

diff --git a/src/vcl/vcl_private.c b/src/vcl/vcl_private.c
index eb01d1c..ba54c91 100644
--- a/src/vcl/vcl_private.c
+++ b/src/vcl/vcl_private.c
@@ -459,8 +459,11 @@
   fifo_segment_free_client_fifo (fs, s->tx_fifo);
   if (s->ct_rx_fifo)
     {
-      fs = fifo_segment_get_segment (&vcm->segment_main,
-				     s->ct_rx_fifo->segment_index);
+      fs = fifo_segment_get_segment_if_valid (&vcm->segment_main,
+					      s->ct_rx_fifo->segment_index);
+      if (!fs)
+	goto done;
+
       fifo_segment_free_client_fifo (fs, s->ct_rx_fifo);
       fifo_segment_free_client_fifo (fs, s->ct_tx_fifo);
     }