commit d1e17a87389989ccc29dcd94eeef137c8b938606
author Florin Coras <fcoras@cisco.com> Fri Feb 16 18:36:32 2024 -0800
committer Florin Coras <florin.coras@gmail.com> Sat Feb 17 02:25:07 2024 +0000
tree 54dea04732baec981757622f2e371d17bb36cfe0
parent 81a6ffced1a5793e2135854501cfb68d40f9c87a

tcp: retransmit fins in last-ack

Fix instances where timers are reset after programming fin.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ib80e3a401d585f388a97c7f2bb62e68ee774d50d

src/vnet/tcp/tcp.c

diff --git a/src/vnet/tcp/tcp.c b/src/vnet/tcp/tcp.c
index c7121b4..a6eb35a 100644
--- a/src/vnet/tcp/tcp.c
+++ b/src/vnet/tcp/tcp.c
@@ -410,8 +410,8 @@
     case TCP_STATE_CLOSE_WAIT:
       if (!transport_max_tx_dequeue (&tc->connection))
 	{
-	  tcp_send_fin (tc);
 	  tcp_connection_timers_reset (tc);
+	  tcp_send_fin (tc);
 	  tcp_connection_set_state (tc, TCP_STATE_LAST_ACK);
 	  tcp_timer_update (&wrk->timer_wheel, tc, TCP_TIMER_WAITCLOSE,
 			    tcp_cfg.lastack_time);