commit d1f05f7f861fca5e54b30acdd17b6d528d1e5eff
author Paul Vinciguerra <pvinci@vinciconsulting.com> Wed Dec 16 21:03:16 2020 -0500
committer Ole Tr�an <otroan@employees.org> Mon Feb 15 09:57:11 2021 +0000
tree c649cd7730a4273c78a39f1624f0fb1ccbc61ad7
parent 1fd1ea253470ea63e9174466daa5de73c4ea7576

tests: explicitly close subprocess files

Resolve the following error:
/vpp/test/framework.py:657: ResourceWarning: unclosed file <_io.BufferedReader name=6>
  del cls.vpp
Object allocated at (most recent call last):
  File "/usr/lib/python3.8/subprocess.py", lineno 844
    self.stdout = io.open(c2pread, 'rb', bufsize)

Type: test

Change-Id: Ia2974da594f0582dcff1f4bdf40d25475769c46c
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

test/framework.py

diff --git a/test/framework.py b/test/framework.py
index c9ecafd..9bb3e01 100644
--- a/test/framework.py
+++ b/test/framework.py
@@ -679,6 +679,8 @@
                 cls.vpp.communicate()
             cls.logger.debug("Deleting class vpp attribute on %s",
                              cls.__name__)
+            cls.vpp.stdout.close()
+            cls.vpp.stderr.close()
             del cls.vpp
 
         if cls.vpp_startup_failed: