commit e31820af10cfdea8baf941ee7df676db92d5b1bb
author Ruslan Babayev <ruslan@babayev.com> Fri Feb 14 17:45:02 2020 -0800
committer Ruslan Babayev <ruslan@babayev.com> Sat May 02 16:06:16 2020 -0700
tree 8a805e4f0c865b262709e93fca372f7f3b7822f5
parent 24b417c481bb2f33d80e8016f871df8ce62ab0bb

vlib: add nosyslog unix option

The "nosyslog" option disables syslog just like the "interactive" mode
but can be used together with "nodaemon".

This is useful for when VPP is running under a process supervisor like
runit or daemontools that pipe the stdout/stderr to a dedicated logger
service.

Type: feature

Change-Id: Ic4287338d6836fea9f3eabdcf960dc1f51875dd1
Signed-off-by: Ruslan Babayev <ruslan@babayev.com>

src/vlib/unix/main.c

diff --git a/src/vlib/unix/main.c b/src/vlib/unix/main.c
index 90601d7..0f9068c 100755
--- a/src/vlib/unix/main.c
+++ b/src/vlib/unix/main.c
@@ -239,8 +239,8 @@
 {
   unix_main_t *um = arg;
 
-  /* Echo to stderr when interactive. */
-  if (um->flags & UNIX_FLAG_INTERACTIVE)
+  /* Echo to stderr when interactive or syslog is disabled. */
+  if (um->flags & (UNIX_FLAG_INTERACTIVE | UNIX_FLAG_NOSYSLOG))
     {
       CLIB_UNUSED (int r) = write (2, msg, msg_len);
     }
@@ -400,6 +400,8 @@
 	um->flags |= UNIX_FLAG_INTERACTIVE;
       else if (unformat (input, "nodaemon"))
 	um->flags |= UNIX_FLAG_NODAEMON;
+      else if (unformat (input, "nosyslog"))
+	um->flags |= UNIX_FLAG_NOSYSLOG;
       else if (unformat (input, "cli-prompt %s", &cli_prompt))
 	vlib_unix_cli_set_prompt (cli_prompt);
       else
@@ -529,7 +531,7 @@
 	}
     }
 
-  if (!(um->flags & UNIX_FLAG_INTERACTIVE))
+  if (!(um->flags & (UNIX_FLAG_INTERACTIVE | UNIX_FLAG_NOSYSLOG)))
     {
       openlog (vm->name, LOG_CONS | LOG_PERROR | LOG_PID, LOG_DAEMON);
       clib_error_register_handler (unix_error_handler, um);
@@ -569,6 +571,11 @@
  * Do not fork or background the VPP process. Typically used when invoking
  * VPP applications from a process monitor.
  *
+ * @cfgcmd{nosyslog}
+ * Do not send e.g. clib_warning(...) output to syslog. Used
+ * when invoking VPP applications from a process monitor which
+ * pipe stdout/stderr to a dedicated logger service.
+ *
  * @cfgcmd{exec, <filename>}
  * @par <code>startup-config &lt;filename&gt;</code>
  * Read startup operational configuration from @c filename.

src/vlib/unix/unix.h

diff --git a/src/vlib/unix/unix.h b/src/vlib/unix/unix.h
index e71b0ba..9fa95a0 100644
--- a/src/vlib/unix/unix.h
+++ b/src/vlib/unix/unix.h
@@ -59,6 +59,8 @@
   /* Run interactively or as daemon (background process). */
 #define UNIX_FLAG_INTERACTIVE (1 << 0)
 #define UNIX_FLAG_NODAEMON (1 << 1)
+#define UNIX_FLAG_NOSYSLOG (1 << 2)
+
 
   /* CLI listen socket. */
   clib_socket_t cli_listen_socket;