commit e8e4b5f9af01b1afa5ba90f0e61fbf924c1c667b
author Dmitry Valter <d-valter@yandex-team.com> Thu Oct 05 08:31:23 2023 +0000
committer Damjan Marion <dmarion@0xa5.net> Tue Oct 24 22:13:43 2023 +0000
tree 345b11e681f9405ebd15d55223ff7aa26c24a7e6
parent 6b027cfdbcb750b8aa1b8ab9a3904c1b2dca6f15

crypto: fix algo selection

Check if crypto ops vector is matching actual ops instead if blindly
dereferencing it.

Type: fix
Signed-off-by: Dmitry Valter <d-valter@yandex-team.com>
Change-Id: Ib88ab44137d9360ee96228e72349a62b2fa7a7e0

src/vnet/crypto/crypto.c

diff --git a/src/vnet/crypto/crypto.c b/src/vnet/crypto/crypto.c
index 0f99492..3cada75 100644
--- a/src/vnet/crypto/crypto.c
+++ b/src/vnet/crypto/crypto.c
@@ -192,13 +192,16 @@
   vnet_crypto_op_id_t opt = 0;
   int i;
 
-  if (alg > vec_len (cm->algs))
+  if (alg >= vec_len (cm->algs))
     return 0;
 
   for (i = 0; i < VNET_CRYPTO_OP_N_TYPES; i++)
     if ((opt = cm->algs[alg].op_by_type[i]) != 0)
       break;
 
+  if (opt >= vec_len (cm->ops_handlers))
+    return 0;
+
   return NULL != cm->ops_handlers[opt];
 }