commit fc3464dac99c9e3e56616e6c6bc6d10886b2f567
author Steven Luong <sluong@cisco.com> Mon Aug 05 14:58:19 2024 -0700
committer Florin Coras <florin.coras@gmail.com> Tue Aug 06 15:52:35 2024 +0000
tree b5fd9aaab6960bdd62ac1c2b1b270825b67f32db
parent 26a6b19a0efb0604103e3d4275406fe6c498f878

session: session_lookup_local_endpoint returns the wrong value

SESSION_INVALID_INDEX is u32. The function is supposed to return u64.
The caller of the function tests the return value to see if it is
SESSION_INVALID_HANDLE in ct_session_connect. If it is not, it
thinks it is a valid handle and calls listen_session_get_from_handle
which causes a crash.

Type: fix

Change-Id: I4ede6b2dfb95259f3a6071cfa3a77ce0d9cd9edd
Signed-off-by: Steven Luong <sluong@cisco.com>

src/vnet/session/session_lookup.c

diff --git a/src/vnet/session/session_lookup.c b/src/vnet/session/session_lookup.c
index 1e58e5e..3a461a5 100644
--- a/src/vnet/session/session_lookup.c
+++ b/src/vnet/session/session_lookup.c
@@ -595,7 +595,7 @@
 
   st = session_table_get (table_index);
   if (!st)
-    return SESSION_INVALID_INDEX;
+    return SESSION_INVALID_HANDLE;
   ASSERT (st->is_local);
 
   if (sep->is_ip4)