commit fd67ece3d3eda0bd896aaa166d89b4f8e7f4e98f
author Neale Ranns <neale.ranns@cisco.com> Thu Nov 02 11:59:14 2017 -0700
committer Damjan Marion <dmarion.lists@gmail.com> Sun Nov 05 11:35:57 2017 +0000
tree f8c725239953a91ba37f783805580cb21159f2e6
parent e4bb5bc7c153ec1b26abae00461aaf19f5541419

Fix coverity warnings in VOM and VAPI

Change-Id: I0db55e079f9b1835668c8efe69e6e6f7f8437b00
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>

src/vpp-api/vapi/vapi.c

diff --git a/src/vpp-api/vapi/vapi.c b/src/vpp-api/vapi/vapi.c
index 25c0b3b..658fd7e 100644
--- a/src/vpp-api/vapi/vapi.c
+++ b/src/vpp-api/vapi/vapi.c
@@ -238,7 +238,7 @@
     {
       return ctx->vl_msg_id_to_vapi_msg_t[vl_msg_id];
     }
-  return ~0;
+  return INVALID_MSG_ID;
 }
 
 vapi_error_e
@@ -337,7 +337,7 @@
       u8 scratch[m->name_with_crc_len + 1];
       memcpy (scratch, m->name_with_crc, m->name_with_crc_len + 1);
       u32 id = vl_api_get_msg_index (scratch);
-      if (~0 != id)
+      if (INVALID_MSG_ID != id)
 	{
 	  if (id > UINT16_MAX)
 	    {
@@ -716,7 +716,7 @@
       vapi_msg_free (ctx, msg);
       return VAPI_EINVAL;
     }
-  if (~0 == (unsigned) ctx->vl_msg_id_to_vapi_msg_t[vpp_id])
+  if (INVALID_MSG_ID == (unsigned) ctx->vl_msg_id_to_vapi_msg_t[vpp_id])
     {
       VAPI_ERR ("Unknown msg ID received, id `%u' marked as not supported",
 		(unsigned) vpp_id);