Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2015 Cisco and/or its affiliates. |
| 3 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | * you may not use this file except in compliance with the License. |
| 5 | * You may obtain a copy of the License at: |
| 6 | * |
| 7 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | * |
| 9 | * Unless required by applicable law or agreed to in writing, software |
| 10 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | * See the License for the specific language governing permissions and |
| 13 | * limitations under the License. |
| 14 | */ |
| 15 | #include <vppinfra/bitmap.h> |
| 16 | #include <vppinfra/hash.h> |
| 17 | #include <vppinfra/pool.h> |
| 18 | #include <vppinfra/timing_wheel.h> |
| 19 | |
| 20 | void |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 21 | timing_wheel_init (timing_wheel_t * w, u64 current_cpu_time, |
| 22 | f64 cpu_clocks_per_second) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 23 | { |
| 24 | if (w->max_sched_time <= w->min_sched_time) |
| 25 | { |
| 26 | w->min_sched_time = 1e-6; |
| 27 | w->max_sched_time = 1e-3; |
| 28 | } |
| 29 | |
| 30 | w->cpu_clocks_per_second = cpu_clocks_per_second; |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 31 | w->log2_clocks_per_bin = |
| 32 | max_log2 (w->cpu_clocks_per_second * w->min_sched_time); |
| 33 | w->log2_bins_per_wheel = |
| 34 | max_log2 (w->cpu_clocks_per_second * w->max_sched_time); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 35 | w->log2_bins_per_wheel -= w->log2_clocks_per_bin; |
| 36 | w->log2_clocks_per_wheel = w->log2_bins_per_wheel + w->log2_clocks_per_bin; |
| 37 | w->bins_per_wheel = 1 << w->log2_bins_per_wheel; |
| 38 | w->bins_per_wheel_mask = w->bins_per_wheel - 1; |
| 39 | |
| 40 | w->current_time_index = current_cpu_time >> w->log2_clocks_per_bin; |
| 41 | |
| 42 | if (w->n_wheel_elt_time_bits <= 0 || |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 43 | w->n_wheel_elt_time_bits >= STRUCT_BITS_OF (timing_wheel_elt_t, |
| 44 | cpu_time_relative_to_base)) |
| 45 | w->n_wheel_elt_time_bits = |
| 46 | STRUCT_BITS_OF (timing_wheel_elt_t, cpu_time_relative_to_base) - 1; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 47 | |
| 48 | w->cpu_time_base = current_cpu_time; |
| 49 | w->time_index_next_cpu_time_base_update |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 50 | = |
| 51 | w->current_time_index + |
| 52 | ((u64) 1 << (w->n_wheel_elt_time_bits - w->log2_clocks_per_bin)); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 53 | } |
| 54 | |
| 55 | always_inline uword |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 56 | get_level_and_relative_time (timing_wheel_t * w, u64 cpu_time, |
| 57 | uword * rtime_result) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 58 | { |
| 59 | u64 dt, rtime; |
| 60 | uword level_index; |
| 61 | |
| 62 | dt = (cpu_time >> w->log2_clocks_per_bin); |
| 63 | |
| 64 | /* Time should always move forward. */ |
| 65 | ASSERT (dt >= w->current_time_index); |
| 66 | |
| 67 | dt -= w->current_time_index; |
| 68 | |
| 69 | /* Find level and offset within level. Level i has bins of size 2^((i+1)*M) */ |
| 70 | rtime = dt; |
| 71 | for (level_index = 0; (rtime >> w->log2_bins_per_wheel) != 0; level_index++) |
| 72 | rtime = (rtime >> w->log2_bins_per_wheel) - 1; |
| 73 | |
| 74 | /* Return offset within level and level index. */ |
| 75 | ASSERT (rtime < w->bins_per_wheel); |
| 76 | *rtime_result = rtime; |
| 77 | return level_index; |
| 78 | } |
| 79 | |
| 80 | always_inline uword |
| 81 | time_index_to_wheel_index (timing_wheel_t * w, uword level_index, u64 ti) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 82 | { |
| 83 | return (ti >> (level_index * w->log2_bins_per_wheel)) & |
| 84 | w->bins_per_wheel_mask; |
| 85 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 86 | |
| 87 | /* Find current time on this level. */ |
| 88 | always_inline uword |
| 89 | current_time_wheel_index (timing_wheel_t * w, uword level_index) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 90 | { |
| 91 | return time_index_to_wheel_index (w, level_index, w->current_time_index); |
| 92 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 93 | |
| 94 | /* Circular wheel indexing. */ |
| 95 | always_inline uword |
| 96 | wheel_add (timing_wheel_t * w, word x) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 97 | { |
| 98 | return x & w->bins_per_wheel_mask; |
| 99 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 100 | |
| 101 | always_inline uword |
| 102 | rtime_to_wheel_index (timing_wheel_t * w, uword level_index, uword rtime) |
| 103 | { |
| 104 | uword t = current_time_wheel_index (w, level_index); |
| 105 | return wheel_add (w, t + rtime); |
| 106 | } |
| 107 | |
| 108 | static clib_error_t * |
| 109 | validate_level (timing_wheel_t * w, uword level_index, uword * n_elts) |
| 110 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 111 | timing_wheel_level_t *level; |
| 112 | timing_wheel_elt_t *e; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 113 | uword wi; |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 114 | clib_error_t *error = 0; |
| 115 | |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 116 | #define _(x) \ |
| 117 | do { \ |
| 118 | error = CLIB_ERROR_ASSERT (x); \ |
| 119 | ASSERT (! error); \ |
| 120 | if (error) return error; \ |
| 121 | } while (0) |
| 122 | |
| 123 | level = vec_elt_at_index (w->levels, level_index); |
| 124 | for (wi = 0; wi < vec_len (level->elts); wi++) |
| 125 | { |
| 126 | /* Validate occupancy bitmap. */ |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 127 | _(clib_bitmap_get_no_check (level->occupancy_bitmap, wi) == |
| 128 | (vec_len (level->elts[wi]) > 0)); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 129 | |
| 130 | *n_elts += vec_len (level->elts[wi]); |
| 131 | |
| 132 | vec_foreach (e, level->elts[wi]) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 133 | { |
| 134 | /* Validate time bin and level. */ |
| 135 | u64 e_time; |
| 136 | uword e_ti, e_li, e_wi; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 137 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 138 | e_time = e->cpu_time_relative_to_base + w->cpu_time_base; |
| 139 | e_li = get_level_and_relative_time (w, e_time, &e_ti); |
| 140 | e_wi = rtime_to_wheel_index (w, level_index, e_ti); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 141 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 142 | if (e_li == level_index - 1) |
| 143 | /* If this element was scheduled on the previous level |
| 144 | it must be wrapped. */ |
| 145 | _(e_ti + current_time_wheel_index (w, level_index - 1) |
| 146 | >= w->bins_per_wheel); |
| 147 | else |
| 148 | { |
| 149 | _(e_li == level_index); |
| 150 | if (e_li == 0) |
| 151 | _(e_wi == wi); |
| 152 | else |
| 153 | _(e_wi == wi || e_wi + 1 == wi || e_wi - 1 == wi); |
| 154 | } |
| 155 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 156 | } |
| 157 | |
| 158 | #undef _ |
| 159 | |
| 160 | return error; |
| 161 | } |
| 162 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 163 | void |
| 164 | timing_wheel_validate (timing_wheel_t * w) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 165 | { |
| 166 | uword l; |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 167 | clib_error_t *error = 0; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 168 | uword n_elts; |
| 169 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 170 | if (!w->validate) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 171 | return; |
| 172 | |
| 173 | n_elts = pool_elts (w->overflow_pool); |
| 174 | for (l = 0; l < vec_len (w->levels); l++) |
| 175 | { |
| 176 | error = validate_level (w, l, &n_elts); |
| 177 | if (error) |
| 178 | clib_error_report (error); |
| 179 | } |
| 180 | } |
| 181 | |
| 182 | always_inline void |
| 183 | free_elt_vector (timing_wheel_t * w, timing_wheel_elt_t * ev) |
| 184 | { |
| 185 | /* Poison free elements so we never use them by mistake. */ |
| 186 | if (CLIB_DEBUG > 0) |
| 187 | memset (ev, ~0, vec_len (ev) * sizeof (ev[0])); |
| 188 | _vec_len (ev) = 0; |
| 189 | vec_add1 (w->free_elt_vectors, ev); |
| 190 | } |
| 191 | |
| 192 | static timing_wheel_elt_t * |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 193 | insert_helper (timing_wheel_t * w, uword level_index, uword rtime) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 194 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 195 | timing_wheel_level_t *level; |
| 196 | timing_wheel_elt_t *e; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 197 | uword wheel_index; |
| 198 | |
| 199 | /* Circular buffer. */ |
| 200 | vec_validate (w->levels, level_index); |
| 201 | level = vec_elt_at_index (w->levels, level_index); |
| 202 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 203 | if (PREDICT_FALSE (!level->elts)) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 204 | { |
| 205 | uword max = w->bins_per_wheel - 1; |
| 206 | clib_bitmap_validate (level->occupancy_bitmap, max); |
| 207 | vec_validate (level->elts, max); |
| 208 | } |
| 209 | |
| 210 | wheel_index = rtime_to_wheel_index (w, level_index, rtime); |
| 211 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 212 | level->occupancy_bitmap = |
| 213 | clib_bitmap_ori (level->occupancy_bitmap, wheel_index); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 214 | |
| 215 | /* Allocate an elt vector from free list if there is one. */ |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 216 | if (!level->elts[wheel_index] && vec_len (w->free_elt_vectors)) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 217 | level->elts[wheel_index] = vec_pop (w->free_elt_vectors); |
| 218 | |
| 219 | /* Add element to vector for this time bin. */ |
| 220 | vec_add2 (level->elts[wheel_index], e, 1); |
| 221 | |
| 222 | return e; |
| 223 | } |
| 224 | |
| 225 | /* Insert user data on wheel at given CPU time stamp. */ |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 226 | static void |
| 227 | timing_wheel_insert_helper (timing_wheel_t * w, u64 insert_cpu_time, |
| 228 | u32 user_data) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 229 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 230 | timing_wheel_elt_t *e; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 231 | u64 dt; |
| 232 | uword rtime, level_index; |
| 233 | |
| 234 | level_index = get_level_and_relative_time (w, insert_cpu_time, &rtime); |
| 235 | |
| 236 | dt = insert_cpu_time - w->cpu_time_base; |
| 237 | if (PREDICT_TRUE (0 == (dt >> BITS (e->cpu_time_relative_to_base)))) |
| 238 | { |
| 239 | e = insert_helper (w, level_index, rtime); |
| 240 | e->user_data = user_data; |
| 241 | e->cpu_time_relative_to_base = dt; |
| 242 | } |
| 243 | else |
| 244 | { |
| 245 | /* Time too far in the future: add to overflow vector. */ |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 246 | timing_wheel_overflow_elt_t *oe; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 247 | pool_get (w->overflow_pool, oe); |
| 248 | oe->user_data = user_data; |
| 249 | oe->cpu_time = insert_cpu_time; |
| 250 | } |
| 251 | } |
| 252 | |
| 253 | always_inline uword |
| 254 | elt_is_deleted (timing_wheel_t * w, u32 user_data) |
| 255 | { |
| 256 | return (hash_elts (w->deleted_user_data_hash) > 0 |
| 257 | && hash_get (w->deleted_user_data_hash, user_data)); |
| 258 | } |
| 259 | |
| 260 | static timing_wheel_elt_t * |
| 261 | delete_user_data (timing_wheel_elt_t * elts, u32 user_data) |
| 262 | { |
| 263 | uword found_match; |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 264 | timing_wheel_elt_t *e, *new_elts; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 265 | |
| 266 | /* Quickly scan to see if there are any elements to delete |
| 267 | in this bucket. */ |
| 268 | found_match = 0; |
| 269 | vec_foreach (e, elts) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 270 | { |
| 271 | found_match = e->user_data == user_data; |
| 272 | if (found_match) |
| 273 | break; |
| 274 | } |
| 275 | if (!found_match) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 276 | return elts; |
| 277 | |
| 278 | /* Re-scan to build vector of new elts with matching user_data deleted. */ |
| 279 | new_elts = 0; |
| 280 | vec_foreach (e, elts) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 281 | { |
| 282 | if (e->user_data != user_data) |
| 283 | vec_add1 (new_elts, e[0]); |
| 284 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 285 | |
| 286 | vec_free (elts); |
| 287 | return new_elts; |
| 288 | } |
| 289 | |
| 290 | /* Insert user data on wheel at given CPU time stamp. */ |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 291 | void |
| 292 | timing_wheel_insert (timing_wheel_t * w, u64 insert_cpu_time, u32 user_data) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 293 | { |
| 294 | /* Remove previously deleted elements. */ |
| 295 | if (elt_is_deleted (w, user_data)) |
| 296 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 297 | timing_wheel_level_t *l; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 298 | uword wi; |
| 299 | |
| 300 | /* Delete elts with given user data so that stale events don't expire. */ |
| 301 | vec_foreach (l, w->levels) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 302 | { |
| 303 | /* *INDENT-OFF* */ |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 304 | clib_bitmap_foreach (wi, l->occupancy_bitmap, ({ |
| 305 | l->elts[wi] = delete_user_data (l->elts[wi], user_data); |
| 306 | if (vec_len (l->elts[wi]) == 0) |
| 307 | l->occupancy_bitmap = clib_bitmap_andnoti (l->occupancy_bitmap, wi); |
| 308 | })); |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 309 | /* *INDENT-ON* */ |
| 310 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 311 | |
| 312 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 313 | timing_wheel_overflow_elt_t *oe; |
| 314 | /* *INDENT-OFF* */ |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 315 | pool_foreach (oe, w->overflow_pool, ({ |
| 316 | if (oe->user_data == user_data) |
| 317 | pool_put (w->overflow_pool, oe); |
| 318 | })); |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 319 | /* *INDENT-ON* */ |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 320 | } |
| 321 | |
| 322 | hash_unset (w->deleted_user_data_hash, user_data); |
| 323 | } |
| 324 | |
| 325 | timing_wheel_insert_helper (w, insert_cpu_time, user_data); |
| 326 | } |
| 327 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 328 | void |
| 329 | timing_wheel_delete (timing_wheel_t * w, u32 user_data) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 330 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 331 | if (!w->deleted_user_data_hash) |
| 332 | w->deleted_user_data_hash = |
| 333 | hash_create ( /* capacity */ 0, /* value bytes */ 0); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 334 | |
| 335 | hash_set1 (w->deleted_user_data_hash, user_data); |
| 336 | } |
| 337 | |
| 338 | /* Returns time of next expiring element. */ |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 339 | u64 |
| 340 | timing_wheel_next_expiring_elt_time (timing_wheel_t * w) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 341 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 342 | timing_wheel_level_t *l; |
| 343 | timing_wheel_elt_t *e; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 344 | uword li, wi, wi0; |
| 345 | u32 min_dt; |
| 346 | u64 min_t; |
| 347 | uword wrapped = 0; |
| 348 | |
| 349 | min_dt = ~0; |
| 350 | min_t = ~0ULL; |
| 351 | vec_foreach (l, w->levels) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 352 | { |
| 353 | if (!l->occupancy_bitmap) |
| 354 | continue; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 355 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 356 | li = l - w->levels; |
| 357 | wi0 = wi = current_time_wheel_index (w, li); |
| 358 | wrapped = 0; |
| 359 | while (1) |
| 360 | { |
| 361 | if (clib_bitmap_get_no_check (l->occupancy_bitmap, wi)) |
| 362 | { |
| 363 | vec_foreach (e, l->elts[wi]) |
| 364 | min_dt = clib_min (min_dt, e->cpu_time_relative_to_base); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 365 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 366 | if (wrapped && li + 1 < vec_len (w->levels)) |
| 367 | { |
| 368 | uword wi1 = current_time_wheel_index (w, li + 1); |
| 369 | if (l[1].occupancy_bitmap |
| 370 | && clib_bitmap_get_no_check (l[1].occupancy_bitmap, wi1)) |
| 371 | { |
| 372 | vec_foreach (e, l[1].elts[wi1]) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 373 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 374 | min_dt = |
| 375 | clib_min (min_dt, e->cpu_time_relative_to_base); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 376 | } |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 377 | } |
| 378 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 379 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 380 | min_t = w->cpu_time_base + min_dt; |
| 381 | goto done; |
| 382 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 383 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 384 | wi = wheel_add (w, wi + 1); |
| 385 | if (wi == wi0) |
| 386 | break; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 387 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 388 | wrapped = wi != wi + 1; |
| 389 | } |
| 390 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 391 | |
| 392 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 393 | timing_wheel_overflow_elt_t *oe; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 394 | |
| 395 | if (min_dt != ~0) |
| 396 | min_t = w->cpu_time_base + min_dt; |
| 397 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 398 | /* *INDENT-OFF* */ |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 399 | pool_foreach (oe, w->overflow_pool, |
| 400 | ({ min_t = clib_min (min_t, oe->cpu_time); })); |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 401 | /* *INDENT-ON* */ |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 402 | |
| 403 | done: |
| 404 | return min_t; |
| 405 | } |
| 406 | } |
| 407 | |
| 408 | static inline void |
| 409 | insert_elt (timing_wheel_t * w, timing_wheel_elt_t * e) |
| 410 | { |
| 411 | u64 t = w->cpu_time_base + e->cpu_time_relative_to_base; |
| 412 | timing_wheel_insert_helper (w, t, e->user_data); |
| 413 | } |
| 414 | |
| 415 | always_inline u64 |
| 416 | elt_cpu_time (timing_wheel_t * w, timing_wheel_elt_t * e) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 417 | { |
| 418 | return w->cpu_time_base + e->cpu_time_relative_to_base; |
| 419 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 420 | |
| 421 | always_inline void |
| 422 | validate_expired_elt (timing_wheel_t * w, timing_wheel_elt_t * e, |
| 423 | u64 current_cpu_time) |
| 424 | { |
| 425 | if (CLIB_DEBUG > 0) |
| 426 | { |
| 427 | u64 e_time = elt_cpu_time (w, e); |
| 428 | |
| 429 | /* Verify that element is actually expired. */ |
| 430 | ASSERT ((e_time >> w->log2_clocks_per_bin) |
| 431 | <= (current_cpu_time >> w->log2_clocks_per_bin)); |
| 432 | } |
| 433 | } |
| 434 | |
| 435 | static u32 * |
| 436 | expire_bin (timing_wheel_t * w, |
| 437 | uword level_index, |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 438 | uword wheel_index, u64 advance_cpu_time, u32 * expired_user_data) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 439 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 440 | timing_wheel_level_t *level = vec_elt_at_index (w->levels, level_index); |
| 441 | timing_wheel_elt_t *e; |
| 442 | u32 *x; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 443 | uword i, j, e_len; |
| 444 | |
| 445 | e = vec_elt (level->elts, wheel_index); |
| 446 | e_len = vec_len (e); |
| 447 | |
| 448 | vec_add2 (expired_user_data, x, e_len); |
| 449 | for (i = j = 0; i < e_len; i++) |
| 450 | { |
| 451 | validate_expired_elt (w, &e[i], advance_cpu_time); |
| 452 | x[j] = e[i].user_data; |
| 453 | |
| 454 | /* Only advance if elt is not to be deleted. */ |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 455 | j += !elt_is_deleted (w, e[i].user_data); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 456 | } |
| 457 | |
| 458 | /* Adjust for deleted elts. */ |
| 459 | if (j < e_len) |
| 460 | _vec_len (expired_user_data) -= e_len - j; |
| 461 | |
| 462 | free_elt_vector (w, e); |
| 463 | |
| 464 | level->elts[wheel_index] = 0; |
| 465 | clib_bitmap_set_no_check (level->occupancy_bitmap, wheel_index, 0); |
| 466 | |
| 467 | return expired_user_data; |
| 468 | } |
| 469 | |
| 470 | /* Called rarely. 32 bit times should only overflow every 4 seconds or so on a fast machine. */ |
Klement Sekera | e5af88c | 2016-11-11 05:58:10 +0100 | [diff] [blame] | 471 | static u32 * |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 472 | advance_cpu_time_base (timing_wheel_t * w, u32 * expired_user_data) |
| 473 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 474 | timing_wheel_level_t *l; |
| 475 | timing_wheel_elt_t *e; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 476 | u64 delta; |
| 477 | |
| 478 | w->stats.cpu_time_base_advances++; |
| 479 | delta = ((u64) 1 << w->n_wheel_elt_time_bits); |
| 480 | w->cpu_time_base += delta; |
| 481 | w->time_index_next_cpu_time_base_update += delta >> w->log2_clocks_per_bin; |
| 482 | |
| 483 | vec_foreach (l, w->levels) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 484 | { |
| 485 | uword wi; |
| 486 | /* *INDENT-OFF* */ |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 487 | clib_bitmap_foreach (wi, l->occupancy_bitmap, ({ |
| 488 | vec_foreach (e, l->elts[wi]) |
| 489 | { |
| 490 | /* This should always be true since otherwise we would have already expired |
| 491 | this element. */ |
| 492 | ASSERT (e->cpu_time_relative_to_base >= delta); |
| 493 | e->cpu_time_relative_to_base -= delta; |
| 494 | } |
| 495 | })); |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 496 | /* *INDENT-ON* */ |
| 497 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 498 | |
| 499 | /* See which overflow elements fit now. */ |
| 500 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 501 | timing_wheel_overflow_elt_t *oe; |
| 502 | /* *INDENT-OFF* */ |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 503 | pool_foreach (oe, w->overflow_pool, ({ |
| 504 | /* It fits now into 32 bits. */ |
| 505 | if (0 == ((oe->cpu_time - w->cpu_time_base) >> BITS (e->cpu_time_relative_to_base))) |
| 506 | { |
| 507 | u64 ti = oe->cpu_time >> w->log2_clocks_per_bin; |
| 508 | if (ti < w->current_time_index) |
| 509 | { |
| 510 | /* This can happen when timing wheel is not advanced for a long time |
| 511 | (for example when at a gdb breakpoint for a while). */ |
| 512 | if (! elt_is_deleted (w, oe->user_data)) |
| 513 | vec_add1 (expired_user_data, oe->user_data); |
| 514 | } |
| 515 | else |
| 516 | timing_wheel_insert_helper (w, oe->cpu_time, oe->user_data); |
| 517 | pool_put (w->overflow_pool, oe); |
| 518 | } |
| 519 | })); |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 520 | /* *INDENT-ON* */ |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 521 | } |
Klement Sekera | e5af88c | 2016-11-11 05:58:10 +0100 | [diff] [blame] | 522 | return expired_user_data; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 523 | } |
| 524 | |
| 525 | static u32 * |
| 526 | refill_level (timing_wheel_t * w, |
| 527 | uword level_index, |
| 528 | u64 advance_cpu_time, |
| 529 | uword from_wheel_index, |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 530 | uword to_wheel_index, u32 * expired_user_data) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 531 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 532 | timing_wheel_level_t *level; |
| 533 | timing_wheel_elt_t *to_insert = w->unexpired_elts_pending_insert; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 534 | u64 advance_time_index = advance_cpu_time >> w->log2_clocks_per_bin; |
| 535 | |
| 536 | vec_validate (w->stats.refills, level_index); |
| 537 | w->stats.refills[level_index] += 1; |
| 538 | |
| 539 | if (level_index + 1 >= vec_len (w->levels)) |
| 540 | goto done; |
| 541 | |
| 542 | level = vec_elt_at_index (w->levels, level_index + 1); |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 543 | if (!level->occupancy_bitmap) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 544 | goto done; |
| 545 | |
| 546 | while (1) |
| 547 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 548 | timing_wheel_elt_t *e, *es; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 549 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 550 | if (clib_bitmap_get_no_check |
| 551 | (level->occupancy_bitmap, from_wheel_index)) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 552 | { |
| 553 | es = level->elts[from_wheel_index]; |
| 554 | level->elts[from_wheel_index] = 0; |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 555 | clib_bitmap_set_no_check (level->occupancy_bitmap, from_wheel_index, |
| 556 | 0); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 557 | |
| 558 | vec_foreach (e, es) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 559 | { |
| 560 | u64 e_time = elt_cpu_time (w, e); |
| 561 | u64 ti = e_time >> w->log2_clocks_per_bin; |
| 562 | if (ti <= advance_time_index) |
| 563 | { |
| 564 | validate_expired_elt (w, e, advance_cpu_time); |
| 565 | if (!elt_is_deleted (w, e->user_data)) |
| 566 | vec_add1 (expired_user_data, e->user_data); |
| 567 | } |
| 568 | else |
| 569 | vec_add1 (to_insert, e[0]); |
| 570 | } |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 571 | free_elt_vector (w, es); |
| 572 | } |
| 573 | |
| 574 | if (from_wheel_index == to_wheel_index) |
| 575 | break; |
| 576 | |
| 577 | from_wheel_index = wheel_add (w, from_wheel_index + 1); |
| 578 | } |
| 579 | |
| 580 | timing_wheel_validate (w); |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 581 | done: |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 582 | w->unexpired_elts_pending_insert = to_insert; |
| 583 | return expired_user_data; |
| 584 | } |
| 585 | |
| 586 | /* Advance wheel and return any expired user data in vector. */ |
| 587 | u32 * |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 588 | timing_wheel_advance (timing_wheel_t * w, u64 advance_cpu_time, |
| 589 | u32 * expired_user_data, |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 590 | u64 * next_expiring_element_cpu_time) |
| 591 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 592 | timing_wheel_level_t *level; |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 593 | uword level_index, advance_rtime, advance_level_index, advance_wheel_index; |
| 594 | uword n_expired_user_data_before; |
| 595 | u64 current_time_index, advance_time_index; |
| 596 | |
| 597 | n_expired_user_data_before = vec_len (expired_user_data); |
| 598 | |
| 599 | /* Re-fill lower levels when time wraps. */ |
| 600 | current_time_index = w->current_time_index; |
| 601 | advance_time_index = advance_cpu_time >> w->log2_clocks_per_bin; |
| 602 | |
| 603 | { |
| 604 | u64 current_ti, advance_ti; |
| 605 | |
| 606 | current_ti = current_time_index >> w->log2_bins_per_wheel; |
| 607 | advance_ti = advance_time_index >> w->log2_bins_per_wheel; |
| 608 | |
| 609 | if (PREDICT_FALSE (current_ti != advance_ti)) |
| 610 | { |
| 611 | if (w->unexpired_elts_pending_insert) |
| 612 | _vec_len (w->unexpired_elts_pending_insert) = 0; |
| 613 | |
| 614 | level_index = 0; |
| 615 | while (current_ti != advance_ti) |
| 616 | { |
| 617 | uword c, a; |
| 618 | c = current_ti & (w->bins_per_wheel - 1); |
| 619 | a = advance_ti & (w->bins_per_wheel - 1); |
| 620 | if (c != a) |
| 621 | expired_user_data = refill_level (w, |
| 622 | level_index, |
| 623 | advance_cpu_time, |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 624 | c, a, expired_user_data); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 625 | current_ti >>= w->log2_bins_per_wheel; |
| 626 | advance_ti >>= w->log2_bins_per_wheel; |
| 627 | level_index++; |
| 628 | } |
| 629 | } |
| 630 | } |
| 631 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 632 | advance_level_index = |
| 633 | get_level_and_relative_time (w, advance_cpu_time, &advance_rtime); |
| 634 | advance_wheel_index = |
| 635 | rtime_to_wheel_index (w, advance_level_index, advance_rtime); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 636 | |
| 637 | /* Empty all occupied bins for entire levels that we advance past. */ |
| 638 | for (level_index = 0; level_index < advance_level_index; level_index++) |
| 639 | { |
| 640 | uword wi; |
| 641 | |
| 642 | if (level_index >= vec_len (w->levels)) |
| 643 | break; |
| 644 | |
| 645 | level = vec_elt_at_index (w->levels, level_index); |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 646 | /* *INDENT-OFF* */ |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 647 | clib_bitmap_foreach (wi, level->occupancy_bitmap, ({ |
| 648 | expired_user_data = expire_bin (w, level_index, wi, advance_cpu_time, |
| 649 | expired_user_data); |
| 650 | })); |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 651 | /* *INDENT-ON* */ |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 652 | } |
| 653 | |
| 654 | if (PREDICT_TRUE (level_index < vec_len (w->levels))) |
| 655 | { |
| 656 | uword wi; |
| 657 | level = vec_elt_at_index (w->levels, level_index); |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 658 | wi = current_time_wheel_index (w, level_index); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 659 | if (level->occupancy_bitmap) |
| 660 | while (1) |
| 661 | { |
| 662 | if (clib_bitmap_get_no_check (level->occupancy_bitmap, wi)) |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 663 | expired_user_data = |
| 664 | expire_bin (w, advance_level_index, wi, advance_cpu_time, |
| 665 | expired_user_data); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 666 | |
| 667 | if (wi == advance_wheel_index) |
| 668 | break; |
| 669 | |
| 670 | wi = wheel_add (w, wi + 1); |
| 671 | } |
| 672 | } |
| 673 | |
| 674 | /* Advance current time index. */ |
| 675 | w->current_time_index = advance_time_index; |
| 676 | |
| 677 | if (vec_len (w->unexpired_elts_pending_insert) > 0) |
| 678 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 679 | timing_wheel_elt_t *e; |
| 680 | vec_foreach (e, w->unexpired_elts_pending_insert) insert_elt (w, e); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 681 | _vec_len (w->unexpired_elts_pending_insert) = 0; |
| 682 | } |
| 683 | |
| 684 | /* Don't advance until necessary. */ |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 685 | while (PREDICT_FALSE |
| 686 | (advance_time_index >= w->time_index_next_cpu_time_base_update)) |
Klement Sekera | e5af88c | 2016-11-11 05:58:10 +0100 | [diff] [blame] | 687 | expired_user_data = advance_cpu_time_base (w, expired_user_data); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 688 | |
| 689 | if (next_expiring_element_cpu_time) |
| 690 | { |
| 691 | u64 min_t; |
| 692 | |
| 693 | /* Anything expired? If so we need to recompute next expiring elt time. */ |
| 694 | if (vec_len (expired_user_data) == n_expired_user_data_before |
| 695 | && w->cached_min_cpu_time_on_wheel != 0ULL) |
| 696 | min_t = w->cached_min_cpu_time_on_wheel; |
| 697 | else |
| 698 | { |
| 699 | min_t = timing_wheel_next_expiring_elt_time (w); |
| 700 | w->cached_min_cpu_time_on_wheel = min_t; |
| 701 | } |
| 702 | |
| 703 | *next_expiring_element_cpu_time = min_t; |
| 704 | } |
| 705 | |
| 706 | return expired_user_data; |
| 707 | } |
| 708 | |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 709 | u8 * |
| 710 | format_timing_wheel (u8 * s, va_list * va) |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 711 | { |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 712 | timing_wheel_t *w = va_arg (*va, timing_wheel_t *); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 713 | int verbose = va_arg (*va, int); |
| 714 | uword indent = format_get_indent (s); |
| 715 | |
| 716 | s = format (s, "level 0: %.4e - %.4e secs, 2^%d - 2^%d clocks", |
| 717 | (f64) (1 << w->log2_clocks_per_bin) / w->cpu_clocks_per_second, |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 718 | (f64) (1 << w->log2_clocks_per_wheel) / |
| 719 | w->cpu_clocks_per_second, w->log2_clocks_per_bin, |
| 720 | w->log2_clocks_per_wheel); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 721 | |
| 722 | if (verbose) |
| 723 | { |
| 724 | int l; |
| 725 | |
| 726 | s = format (s, "\n%Utime base advances %Ld, every %.4e secs", |
| 727 | format_white_space, indent + 2, |
| 728 | w->stats.cpu_time_base_advances, |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 729 | (f64) ((u64) 1 << w->n_wheel_elt_time_bits) / |
| 730 | w->cpu_clocks_per_second); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 731 | |
| 732 | for (l = 0; l < vec_len (w->levels); l++) |
| 733 | s = format (s, "\n%Ulevel %d: refills %Ld", |
| 734 | format_white_space, indent + 2, |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 735 | l, |
| 736 | l < |
| 737 | vec_len (w->stats.refills) ? w->stats. |
| 738 | refills[l] : (u64) 0); |
Ed Warnicke | cb9cada | 2015-12-08 15:45:58 -0700 | [diff] [blame] | 739 | } |
| 740 | |
| 741 | return s; |
| 742 | } |
Dave Barach | c379999 | 2016-08-15 11:12:27 -0400 | [diff] [blame] | 743 | |
| 744 | /* |
| 745 | * fd.io coding-style-patch-verification: ON |
| 746 | * |
| 747 | * Local Variables: |
| 748 | * eval: (c-set-style "gnu") |
| 749 | * End: |
| 750 | */ |