blob: 154e6f1e7ef5c342302931135865dc4649286065 [file] [log] [blame]
Todd Foggoaa292c8c2016-04-06 09:57:01 -04001From e89ea2a038987102d9eb0a7ea217d7a301b484cb Mon Sep 17 00:00:00 2001
2From: John Daley <johndale@cisco.com>
3Date: Thu, 24 Mar 2016 14:00:39 -0700
4Subject: [PATCH 21/22] enic: fix TX hang when number of packets > queue
5 size
John Lo23650e62016-03-29 16:14:35 -04006
John Lo23650e62016-03-29 16:14:35 -04007 If the nb_pkts parameter to rte_eth_tx_burst() was greater than
8 the TX descriptor count, a completion was not being requested
9 from the NIC, so descriptors would not be released back to the
10 host causing a lock-up.
Todd Foggoaa292c8c2016-04-06 09:57:01 -040011
John Lo23650e62016-03-29 16:14:35 -040012 Introduce a limit of how many TX descriptors can be used in a single
13 call to the enic PMD burst TX function before requesting a completion.
Todd Foggoaa292c8c2016-04-06 09:57:01 -040014
John Lo23650e62016-03-29 16:14:35 -040015 Fixes: d739ba4c6abf ("enic: improve Tx packet rate")
Todd Foggoaa292c8c2016-04-06 09:57:01 -040016
John Lo23650e62016-03-29 16:14:35 -040017 Signed-off-by: John Daley <johndale@cisco.com>
Todd Foggoaa292c8c2016-04-06 09:57:01 -040018---
19 drivers/net/enic/enic_ethdev.c | 20 ++++++++++++++++----
20 drivers/net/enic/enic_res.h | 1 +
21 2 files changed, 17 insertions(+), 4 deletions(-)
John Lo23650e62016-03-29 16:14:35 -040022
23diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
Todd Foggoaa292c8c2016-04-06 09:57:01 -040024index 6c3c734..61bb83c 100644
John Lo23650e62016-03-29 16:14:35 -040025--- a/drivers/net/enic/enic_ethdev.c
26+++ b/drivers/net/enic/enic_ethdev.c
Todd Foggoaa292c8c2016-04-06 09:57:01 -040027@@ -510,7 +510,7 @@ static void enicpmd_remove_mac_addr(struct rte_eth_dev *eth_dev, __rte_unused ui
John Lo23650e62016-03-29 16:14:35 -040028 static uint16_t enicpmd_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
29 uint16_t nb_pkts)
30 {
31- unsigned int index;
32+ uint16_t index;
33 unsigned int frags;
34 unsigned int pkt_len;
35 unsigned int seg_len;
Todd Foggoaa292c8c2016-04-06 09:57:01 -040036@@ -522,6 +522,7 @@ static uint16_t enicpmd_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
John Lo23650e62016-03-29 16:14:35 -040037 unsigned short vlan_id;
38 unsigned short ol_flags;
39 uint8_t last_seg, eop;
40+ unsigned int host_tx_descs = 0;
41
42 for (index = 0; index < nb_pkts; index++) {
43 tx_pkt = *tx_pkts++;
Todd Foggoaa292c8c2016-04-06 09:57:01 -040044@@ -537,6 +538,7 @@ static uint16_t enicpmd_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
John Lo23650e62016-03-29 16:14:35 -040045 return index;
46 }
47 }
48+
49 pkt_len = tx_pkt->pkt_len;
50 vlan_id = tx_pkt->vlan_tci;
51 ol_flags = tx_pkt->ol_flags;
Todd Foggoaa292c8c2016-04-06 09:57:01 -040052@@ -546,9 +548,19 @@ static uint16_t enicpmd_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
John Lo23650e62016-03-29 16:14:35 -040053 next_tx_pkt = tx_pkt->next;
54 seg_len = tx_pkt->data_len;
55 inc_len += seg_len;
56- eop = (pkt_len == inc_len) || (!next_tx_pkt);
57- last_seg = eop &&
58- (index == ((unsigned int)nb_pkts - 1));
59+
60+ host_tx_descs++;
61+ last_seg = 0;
62+ eop = 0;
63+ if ((pkt_len == inc_len) || !next_tx_pkt) {
64+ eop = 1;
65+ /* post if last packet in batch or > thresh */
66+ if ((index == (nb_pkts - 1)) ||
67+ (host_tx_descs > ENIC_TX_POST_THRESH)) {
68+ last_seg = 1;
69+ host_tx_descs = 0;
70+ }
71+ }
72 enic_send_pkt(enic, wq, tx_pkt, (unsigned short)seg_len,
73 !frags, eop, last_seg, ol_flags, vlan_id);
74 tx_pkt = next_tx_pkt;
75diff --git a/drivers/net/enic/enic_res.h b/drivers/net/enic/enic_res.h
76index 33f2e84..00fa71d 100644
77--- a/drivers/net/enic/enic_res.h
78+++ b/drivers/net/enic/enic_res.h
79@@ -53,6 +53,7 @@
80
81 #define ENIC_NON_TSO_MAX_DESC 16
82 #define ENIC_DEFAULT_RX_FREE_THRESH 32
83+#define ENIC_TX_POST_THRESH (ENIC_MIN_WQ_DESCS / 2)
84
85 #define ENIC_SETTING(enic, f) ((enic->config.flags & VENETF_##f) ? 1 : 0)
86
Todd Foggoaa292c8c2016-04-06 09:57:01 -040087--
881.9.1
89