Refactor jobs for introduction of Centos7 support

engine is currently being updated to introduce support for Centos7.
During that work, engine code has been refactored, aligning how things
are called and done when it comes to various configuration options based
on the distribution.

Engine now uses single variable to do things based on the distribution
selected by user using -o argument. This argument can take either ubuntu1804
or centos7. Based on that, we determine DIB stuff using vars files per
distro. This results in the removal of DIB parameters from jobs and DISTRIBUTION
parameter and only use DISTRO parameter which is then used by engine
accordingly.

Centos7 jobs for engine and scenario verification are enabled in a none-voting
fashion so if they fail due to development work, they will not block a change
from being merged. Only Ubuntu1804 jobs will vote until we prove Centos7 works
for all the scenarios we have.

Periodic jobs for engine and scenario are not enabled for Centos7 in order not
to waste the resources we have until Centos7 is proving to be working.

Change-Id: I09ab256ce1904b2c9d7b968e3be399ff82c099aa
diff --git a/jjb/cloud-infra/cloud-infra-verify-scenario.yaml b/jjb/cloud-infra/cloud-infra-verify-scenario.yaml
index fa47312..5b300a5 100644
--- a/jjb/cloud-infra/cloud-infra-verify-scenario.yaml
+++ b/jjb/cloud-infra/cloud-infra-verify-scenario.yaml
@@ -49,13 +49,19 @@
           branch: '{stream}'
           disabled: 'false'
 
-    os:
+    distro:
       - ubuntu1804:
-          disabled: 'false'
-          distribution: 'ubuntu18'
-          ipa_dib_os_element: 'coreos'
-          dib_os_release: 'bionic'
-          dib_os_element: 'ubuntu-minimal'
+          disabled: false
+          successful: false
+          failed: false
+          unstable: false
+          notbuilt: false
+      - centos7:
+          disabled: false
+          successful: true
+          failed: true
+          unstable: true
+          notbuilt: true
 
     type:
       - virtual:
@@ -68,11 +74,11 @@
           build-timeout: 30
 
     jobs:
-      - 'cloud-infra-verify-scenario-{os}-{type}-{stream}'
-      - 'cloud-infra-verify-scenario-{os}-{phase}-{type}-{stream}'
+      - 'cloud-infra-verify-scenario-{distro}-{type}-{stream}'
+      - 'cloud-infra-verify-scenario-{distro}-{phase}-{type}-{stream}'
 
 - job-template:
-    name: 'cloud-infra-verify-scenario-{os}-{type}-{stream}'
+    name: 'cloud-infra-verify-scenario-{distro}-{type}-{stream}'
 
     project-type: multijob
 
@@ -90,8 +96,8 @@
           default: '{slave-label}'
           description: 'Slave label to schedule this job on. All slaves have Ubuntu1604 no matter what distro target nodes use'
       - string:
-          name: DISTRIBUTION
-          default: '{distribution}'
+          name: DISTRO
+          default: '{distro}'
           description: 'Distribution to use for configuring target nodes (networking etc.)'
       - string:
           name: DEPLOY_TYPE
@@ -102,18 +108,6 @@
           default: 'true'
           description: 'Use prebuilt deployment image while running as part of CI/CD'
       - string:
-          name: IPA_DIB_OS_ELEMENT
-          default: '{ipa_dib_os_element}'
-          description: 'DIB OS Element to use for building the ramdisk image'
-      - string:
-          name: DIB_OS_RELEASE
-          default: '{dib_os_release}'
-          description: 'DIB OS Release to use for building the deployment image to provision target nodes with'
-      - string:
-          name: DIB_OS_ELEMENT
-          default: '{dib_os_element}'
-          description: 'DIB OS Element to use for building the deployment image to provision target nodes with'
-      - string:
           name: TEST_SUITE
           default: 'healthcheck'
           description: 'Test suite to run'
@@ -127,9 +121,9 @@
       - build-blocker:
           use-build-blocker: true
           blocking-jobs:
-            - 'cloud-infra-verify-engine-{os}-.*'
-            - 'cloud-infra-verify-scenario-{os}-.*'
-            - 'cloud-infra-periodic-engine-{os}-.*'
+            - 'cloud-infra-verify-engine-{distro}-.*'
+            - 'cloud-infra-verify-scenario-{distro}-.*'
+            - 'cloud-infra-periodic-engine-{distro}-.*'
             - 'cloud-infra-os-.*'
             - 'cloud-infra-k8-.*'
           block-level: 'NODE'
@@ -154,6 +148,12 @@
           project: 'infra\/swconfig'
           branch: '{branch}'
           files: '**'
+          custom-url: '* $JOB_NAME $BUILD_URL'
+          skip-vote:
+            successful: '{obj:successful}'
+            failed: '{obj:failed}'
+            unstable: '{obj:unstable}'
+            notbuilt: '{obj:notbuilt}'
 
     builders:
       - 'cloud-infra-determine-scenario-macro'
@@ -161,15 +161,12 @@
           name: deploy
           condition: SUCCESSFUL
           projects:
-            - name: 'cloud-infra-verify-scenario-{os}-deploy-{type}-{stream}'
+            - name: 'cloud-infra-verify-scenario-{distro}-deploy-{type}-{stream}'
               current-parameters: true
               predefined-parameters: |
-                DISTRIBUTION=$DISTRIBUTION
+                DISTRO=$DISTRO
                 DEPLOY_TYPE=$DEPLOY_TYPE
                 USE_PREBUILT_DEPLOYMENT_IMAGE=$USE_PREBUILT_DEPLOYMENT_IMAGE
-                IPA_DIB_OS_ELEMENT=$IPA_DIB_OS_ELEMENT
-                DIB_OS_RELEASE=$DIB_OS_RELEASE
-                DIB_OS_ELEMENT=$DIB_OS_ELEMENT
                 CLEANUP=$CLEANUP
                 GERRIT_PROJECT=$GERRIT_PROJECT
                 GERRIT_BRANCH=$GERRIT_BRANCH
@@ -183,15 +180,12 @@
           name: functest
           condition: SUCCESSFUL
           projects:
-            - name: 'cloud-infra-verify-scenario-{os}-functest-{type}-{stream}'
+            - name: 'cloud-infra-verify-scenario-{distro}-functest-{type}-{stream}'
               current-parameters: true
               predefined-parameters: |
-                DISTRIBUTION=$DISTRIBUTION
+                DISTRO=$DISTRO
                 DEPLOY_TYPE=$DEPLOY_TYPE
                 USE_PREBUILT_DEPLOYMENT_IMAGE=$USE_PREBUILT_DEPLOYMENT_IMAGE
-                IPA_DIB_OS_ELEMENT=$IPA_DIB_OS_ELEMENT
-                DIB_OS_RELEASE=$DIB_OS_RELEASE
-                DIB_OS_ELEMENT=$DIB_OS_ELEMENT
                 TEST_SUITE=$TEST_SUITE
                 CLEANUP=$CLEANUP
                 GERRIT_PROJECT=$GERRIT_PROJECT
@@ -204,7 +198,7 @@
               abort-all-job: true
 
 - job-template:
-    name: 'cloud-infra-verify-scenario-{os}-{phase}-{type}-{stream}'
+    name: 'cloud-infra-verify-scenario-{distro}-{phase}-{type}-{stream}'
 
     disabled: false
 
@@ -218,8 +212,8 @@
           name: PROJECT
           default: $GERRIT_PROJECT
       - string:
-          name: DISTRIBUTION
-          default: 'ubuntu18'
+          name: DISTRO
+          default: 'ubuntu1804'
           description: 'Distribution to use for configuring target nodes (networking etc.). Overriden by upstream job.'
       - string:
           name: DEPLOY_TYPE
@@ -230,18 +224,6 @@
           default: 'false'
           description: 'Use prebuilt deployment image while running as part of CI/CD'
       - string:
-          name: IPA_DIB_OS_ELEMENT
-          default: 'fedora'
-          description: 'DIB OS Element to use for building the ramdisk image. Overriden by upstream job.'
-      - string:
-          name: DIB_OS_RELEASE
-          default: 'bionic'
-          description: 'DIB OS Release to use for building the deployment image to provision target nodes with. Overriden by upstream job.'
-      - string:
-          name: DIB_OS_ELEMENT
-          default: 'ubuntu-minimal'
-          description: 'DIB OS Element to use for building the deployment image to provision target nodes with. Overriden by upstream job.'
-      - string:
           name: TEST_FW
           default: '{phase}'
           description: 'Test framework to use'