commit 45956acf280210e31e894a8adf923cb2bb0eab7e
author Fatih Degirmenci <fdegir@gmail.com> Mon Dec 16 10:53:15 2019 +0100
committer Fatih Degirmenci <fdegir@gmail.com> Tue Apr 21 08:29:29 2020 +0000
tree 6d276891a917c506705c2a55d82965ae73073988
parent 572223c0fd5a85942ff48e88a665fc0775292b9d

Fix shellcheck warnings

Change-Id: I9f7c3ba79dce787646f8fa8f7693ce9ff5e24ff2

install.sh

diff --git a/install.sh b/install.sh
index 4e81764..545e7ea 100755
--- a/install.sh
+++ b/install.sh
@@ -21,7 +21,7 @@
 set -o nounset
 set -o pipefail
 
-INSTALLER_ROOT_DIR="$(dirname $(realpath ${BASH_SOURCE[0]}))"
+INSTALLER_ROOT_DIR="$(dirname "$(realpath "${BASH_SOURCE[0]}")")"
 export ANSIBLE_ROLES_PATH="$HOME/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles:${ENGINE_PATH}/engine/playbooks/roles:${ENGINE_CACHE}/repos/bifrost/playbooks/roles"
 export ANSIBLE_LIBRARY="$HOME/.ansible/plugins/modules:/usr/share/ansible/plugins/modules:${ENGINE_CACHE}/repos/bifrost/playbooks/library"
 
@@ -29,37 +29,37 @@
 echo "-------------------------------------------------------------------------"
 echo "Info: Configure target hosts"
 echo "-------------------------------------------------------------------------"
-cd ${ENGINE_PATH}
-ansible-playbook ${ENGINE_ANSIBLE_PARAMS} \
-  -i ${ENGINE_CACHE}/config/inventory.ini \
-  ${INSTALLER_ROOT_DIR}/playbooks/configure-targethosts.yml
+cd "${ENGINE_PATH}"
+ansible-playbook "${ENGINE_ANSIBLE_PARAMS}" \
+  -i "${ENGINE_CACHE}/config/inventory.ini" \
+  "${INSTALLER_ROOT_DIR}/playbooks/configure-targethosts.yml"
 
 # configure installer
 echo "-------------------------------------------------------------------------"
 echo "Info: Configure installer"
 echo "-------------------------------------------------------------------------"
-cd ${ENGINE_PATH}
-ansible-playbook ${ENGINE_ANSIBLE_PARAMS} \
-  -i ${ENGINE_CACHE}/config/inventory.ini \
-  ${INSTALLER_ROOT_DIR}/playbooks/configure-installer.yml
+cd "${ENGINE_PATH}"
+ansible-playbook "${ENGINE_ANSIBLE_PARAMS}" \
+  -i "${ENGINE_CACHE}/config/inventory.ini" \
+  "${INSTALLER_ROOT_DIR}/playbooks/configure-installer.yml"
 
 # bootstrap scenario
 echo "-------------------------------------------------------------------------"
 echo "Info: Execute scenario pre deployment tasks"
 echo "-------------------------------------------------------------------------"
-cd ${ENGINE_PATH}
-ansible-playbook ${ENGINE_ANSIBLE_PARAMS} \
-  -i ${ENGINE_CACHE}/config/inventory.ini \
-  ${INSTALLER_ROOT_DIR}/playbooks/pre-deployment.yml
+cd "${ENGINE_PATH}"
+ansible-playbook "${ENGINE_ANSIBLE_PARAMS}" \
+  -i "${ENGINE_CACHE}/config/inventory.ini" \
+  "${INSTALLER_ROOT_DIR}/playbooks/pre-deployment.yml"
 
 # install scenario
 echo "-------------------------------------------------------------------------"
 echo "Info: Install scenario ${DEPLOY_SCENARIO}"
 echo "-------------------------------------------------------------------------"
-cd ${ENGINE_CACHE}/repos/kubespray
-ansible-playbook ${ENGINE_ANSIBLE_PARAMS} \
+cd "${ENGINE_CACHE}/repos/kubespray"
+ansible-playbook "${ENGINE_ANSIBLE_PARAMS}" \
   -i inventory/engine/inventory.ini \
-  -e @${ENGINE_CACHE}/config/kubespray-extra-vars.yml \
+  -e "@${ENGINE_CACHE}/config/kubespray-extra-vars.yml" \
   --flush-cache \
   cluster.yml
 
@@ -67,9 +67,9 @@
 echo "-------------------------------------------------------------------------"
 echo "Info: Execute scenario and common post deployment tasks"
 echo "-------------------------------------------------------------------------"
-cd ${ENGINE_PATH}
-ansible-playbook ${ENGINE_ANSIBLE_PARAMS} \
-  -i ${ENGINE_CACHE}/config/inventory.ini \
-  ${INSTALLER_ROOT_DIR}/playbooks/post-deployment.yml
+cd "${ENGINE_PATH}"
+ansible-playbook "${ENGINE_ANSIBLE_PARAMS}" \
+  -i "${ENGINE_CACHE}/config/inventory.ini" \
+  "${INSTALLER_ROOT_DIR}/playbooks/post-deployment.yml"
 
 # vim: set ts=2 sw=2 expandtab: