commit | b6977d2f7ce64ece732ac1a1a0525dac972d7ccf | [log] [tgz] |
---|---|---|
author | Jim Hahn <jrh3@att.com> | Wed Feb 17 15:23:38 2021 -0500 |
committer | Jim Hahn <jrh3@att.com> | Thu Feb 18 17:47:55 2021 +0000 |
tree | 4966f5aa4737b0fef8241989eb216cce7fbe9294 | |
parent | 4e05982e36aa66b83fa0ee44b9631412442c3969 [diff] |
Fix sonars in apex-pdp Addressed the following issues: - initialize mocks before use - use parameterized queries - Random() is not secure - provide parameterized type for generics - unused imports - constructor visibility - use compute() instead of containsKey()/put() - make final fields static - rename constants to all upper case - no assert() in Thread.run() methods - nested try - nested if/else - too many break/continue - use try-with-resources - repeatable annotations - overlapping characters in reg ex - hashcode is not sufficient in compareTo() - need equals() with compareTo() - make class an interface - use parameterized test - multiple calls in assert() - log or re-throw - use different type of lambda - use parameterized logging - use StringBuilder instead of concatenation - use StandardCharsets.UTF_8 Issue-ID: POLICY-2906 Change-Id: I2cf8c885e3e22c2c6cbe6403a34906928afad022 Signed-off-by: Jim Hahn <jrh3@att.com>
Copyright (C) 2016-2018 Ericsson. All rights reserved. This file is licensed under the CREATIVE COMMONS ATTRIBUTION 4.0 INTERNATIONAL LICENSE Full license text at https://creativecommons.org/licenses/by/4.0/legalcode
This source repository contains the ONAP Policy APEX PDP Engine code. The settings file only needs to support the standard Maven repositories (e.g. central = http://repo1.maven.org/maven2/), and any proxy settings needed in your environment.
To build it using Maven 3, run: mvn clean install