commit b66daa5aa2d3fa3645f579bfd7a69ccf5a48be2f
author rameshiyer27 <ramesh.murugan.iyer@est.tech> Mon Mar 21 00:00:03 2022 +0000
committer rameshiyer27 <ramesh.murugan.iyer@est.tech> Tue Mar 22 13:16:48 2022 +0000
tree f650459ca535ef4d199f4cf18b0112b95c7c426d
parent 2e15dfa79186f731920003abaaa208b4829fe606

Fix spring transaction issue in getNodetemplates

changes on the db service template object gets auto updated to the db
by spring transaction. Creating new object copy to avoid the same.

Issue-ID: POLICY-3934
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: I0dbd5cb9d2c1119b2f263f60ed470bc8fef85d1e

main/src/main/java/org/onap/policy/api/main/service/ToscaServiceTemplateService.java

diff --git a/main/src/main/java/org/onap/policy/api/main/service/ToscaServiceTemplateService.java b/main/src/main/java/org/onap/policy/api/main/service/ToscaServiceTemplateService.java
index d578d0d..2e8fc9e 100644
--- a/main/src/main/java/org/onap/policy/api/main/service/ToscaServiceTemplateService.java
+++ b/main/src/main/java/org/onap/policy/api/main/service/ToscaServiceTemplateService.java
@@ -550,14 +550,13 @@
         throws PfModelException {
         LOGGER.debug("->getNodeTemplate: name={}, version={}", name, version);
         List<ToscaNodeTemplate> nodeTemplates = new ArrayList<>();
-        var jpaNodeTemplates = new JpaToscaNodeTemplates();
 
         var dbServiceTemplate = getDefaultJpaToscaServiceTemplate();
         //Return empty if no nodeTemplates present in db
         if (!ToscaUtils.doNodeTemplatesExist(dbServiceTemplate)) {
             return nodeTemplates;
         }
-        jpaNodeTemplates = dbServiceTemplate.getTopologyTemplate().getNodeTemplates();
+        var jpaNodeTemplates = new JpaToscaNodeTemplates(dbServiceTemplate.getTopologyTemplate().getNodeTemplates());
 
         //Filter specific nodeTemplates
         if (name != null && version != null) {