commit 9f9131575d2e2b1002a3e108f7793a97fa7652ab
author Jim Hahn <jrh3@att.com> Mon Apr 06 12:17:11 2020 -0400
committer Jim Hahn <jrh3@att.com> Mon Apr 06 13:00:04 2020 -0400
tree 68400e6ac1fb32f01f8338803a7d72bdb41215b1
parent a56d3929f2387252525577fb36f9e03933064b8f

Address sonar issues in ONAP-logging

Addressed the following sonar issues in ONAP-logging:
- use Map instead of ConcurrentHashMap
- remove unusued fields
- use Map.computeIfAbsent() instead of get()/put() pair
- readObject is unsafe
- use try-with-resources
- junit should assert something

Also removed some unused imports.

Issue-ID: POLICY-2305
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I3480a55da4d0e771f8083c97770a6c9707d871f7
Signed-off-by: Jim Hahn <jrh3@att.com>

common-logging/pom.xml

diff --git a/common-logging/pom.xml b/common-logging/pom.xml
index 1fef17a..a87d31a 100644
--- a/common-logging/pom.xml
+++ b/common-logging/pom.xml
@@ -67,6 +67,11 @@
             <artifactId>commons-lang3</artifactId>
         </dependency>
         <dependency>
+            <groupId>org.assertj</groupId>
+            <artifactId>assertj-core</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
             <groupId>org.powermock</groupId>
             <artifactId>powermock-api-mockito2</artifactId>
             <scope>test</scope>