| commit | a56d3929f2387252525577fb36f9e03933064b8f | [log] [tgz] |
|---|---|---|
| author | Jim Hahn <jrh3@att.com> | Fri Apr 03 09:44:26 2020 -0400 |
| committer | Jim Hahn <jrh3@att.com> | Mon Apr 06 09:41:59 2020 -0400 |
| tree | 4b671549b5f1c0513c31d77baa19821e422f41e7 | |
| parent | 7da3ddfa40de2f683a2d423d62b78a8d001108eb [diff] |
Address sonar issues in common Addressed the following sonar issues: - missing assertion in junit test case - disable sonars about setAccessible() as it's required for jackson emulation - sleep in junit - don't use wild-cards (e.g., "*") with java.util Pattern - use re2j instead of java.util Pattern - use String methods (e.g., startsWith()) - duplicate method bodies - duplicate code in Coder classes - string concatenation in logger calls - UTF-8 encoding - return primitive instead of boxed primitive - add assertion to tests - renamed support methods from doTestXxx to verifyXxx - cognitive complexity - use AtomicRef instead of volatile - use specific Functionals (e.g., IntConsumer) - function always returns the same value - serializable vs transient Issue-ID: POLICY-2305 Change-Id: I08eb7aa495a80bdc1d26827ba17a7946c83b9828 Signed-off-by: Jim Hahn <jrh3@att.com>
Copyright 2018 AT&T Intellectual Property. All rights reserved. This file is licensed under the CREATIVE COMMONS ATTRIBUTION 4.0 INTERNATIONAL LICENSE Full license text at https://creativecommons.org/licenses/by/4.0/legalcode
This source repository contains ONAP common code, which is shared by 'policy-drools-pdp' and 'policy-engine'. To build it: