| commit | d6aa3faba917b45e01f5001fe3a768feddedc798 | [log] [tgz] |
|---|---|---|
| author | Jim Hahn <jrh3@att.com> | Fri Jun 21 13:19:31 2019 -0400 |
| committer | Jim Hahn <jrh3@att.com> | Fri Jun 21 17:19:09 2019 -0400 |
| tree | 077a51a89320f558f08b2d0512f6cf63450ae90d | |
| parent | c9392e1a126de54ae8a0e1f3316729e878115300 [diff] |
Fix sonar issues in integrity monitor Used Eclipse Refactor->Extract Method to reduce cyclomatic complexity. Flattened nested FpManager class into IntegrityMonitor class. Changed some strings to StringBuilder, where lots of concatenation was being done. Simplified some things by eliminating some try/catch blocks where an exception can't actually (except may an out-of-memory exception). Also addressed some sonar issues in the tests (e.g., use "<>" where appropriate). Eliminated some assertException methods, replacing them with assertj methods. Did not attempt to increase junit coverage. Change-Id: I311acaffcd87f0cbbf382c06c7fa26177007abd5 Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
Copyright 2018 AT&T Intellectual Property. All rights reserved. This file is licensed under the CREATIVE COMMONS ATTRIBUTION 4.0 INTERNATIONAL LICENSE Full license text at https://creativecommons.org/licenses/by/4.0/legalcode
This source repository contains ONAP common code, which is shared by 'policy-drools-pdp' and 'policy-engine'. To build it: