| commit | ea262e6da52fd4da0733f02998f87aebaf502ddb | [log] [tgz] |
|---|---|---|
| author | Jim Hahn <jrh3@att.com> | Wed Jun 12 14:32:25 2019 -0400 |
| committer | Jim Hahn <jrh3@att.com> | Wed Jun 12 17:36:59 2019 -0400 |
| tree | a7cded567521f0141f31d9f8c185eccdaf2a8979 | |
| parent | e671e9fa5d09ec696cb24aeefaf10ddbc7c705d7 [diff] |
Apply simple sonar fixes Note: A number of these were identified, by SonarLint, in the Test classes, which are not typically scanned by Sonar. Removed unnecessary imports. Removed unneeded "throws Xxx". Replaced lambda with method references. Replaced duplicate strings with constants. Replaced try-fail-catch with assert-j methods to eliminate sonar complaints about duplicate failure messages. Added missing @Override annotations. Use map.computeIfAbsent() where appropriate. Also fixed some minor checkstyle issues. Removed unneeded "volatile" declarations. Replaced some if-else constructs with "?:" construct, per sonar. Replaced Object.wait() with CountDownLatch.await(); according to sonar (and javadocs), Object.wait() can return due to "spurious wakeups". Fixed issue whereby CryptoUtilsTest wouldn't run in my Eclipse. Change-Id: Ib6b71ed65662cfd6209400dac57ed69279bf29ec Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
Copyright 2018 AT&T Intellectual Property. All rights reserved. This file is licensed under the CREATIVE COMMONS ATTRIBUTION 4.0 INTERNATIONAL LICENSE Full license text at https://creativecommons.org/licenses/by/4.0/legalcode
This source repository contains ONAP common code, which is shared by 'policy-drools-pdp' and 'policy-engine'. To build it: