Fix new sonars in drools-apps

Addressed the following sonars:
- too many assertions in test method
- rename test class
- use static method to modify static field
- use already defined constant
- code always returns the same value
- use assertNotSame
- use appropriate class name to access static method
- define a constant
- extract nested try block
- don't always return the same value
- use remove() instead of set(null) for thread-local-storage
- add @Override

Issue-ID: POLICY-2852
Change-Id: Icc62acd4ad57afa2d44ed4cdca504a3ac0810228
Signed-off-by: Jim Hahn <jrh3@att.com>
10 files changed
tree: 7b0d2df1aefbb3635788af501be1157fbe05d798
  1. controlloop/
  2. releases/
  3. testsuites/
  4. .gitignore
  5. .gitreview
  6. checkstyle-suppressions.xml
  7. INFO.yaml
  8. LICENSE.txt
  9. lombok.config
  10. pom.xml
  11. README.md
  12. version.properties
README.md

Copyright 2018-2020 AT&T Intellectual Property. All rights reserved. This file is licensed under the CREATIVE COMMONS ATTRIBUTION 4.0 INTERNATIONAL LICENSE Full license text at https://creativecommons.org/licenses/by/4.0/legalcode

This source repository contains ONAP Policy application code. To build it:

  1. using Maven 3
  2. git clone http://gerrit.onap.org/r/oparent and copy oparent/settings.xml to ~/.m2
  3. mvn -Pdocker clean install